-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Azure Blob backup support #5674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Please see note inline.
I'll let @enisoc approve once all feedback has been addressed.
@dkhenry ping |
This adds initial support for Azure blob service as a backup target Signed-off-by: Dan Kozlowski <[email protected]>
Giving Env paramaters for secrets, not just CLI. Rename prefix to be storage_root i.a.w what we do for s3 and gcs Signed-off-by: Dan Kozlowski <[email protected]>
Signed-off-by: Dan Kozlowski <[email protected]>
d2ad9f3
to
aae83c4
Compare
Signed-off-by: Dan Kozlowski <[email protected]>
Signed-off-by: Dan Kozlowski <[email protected]>
Signed-off-by: Dan Kozlowski <[email protected]>
Signed-off-by: Dan Kozlowski <[email protected]>
Signed-off-by: Anthony Yeh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FYI I pushed an extra commit with the changes we discussed offline.
This adds initial support for Azure blob service as a backup target
Closes #3580