Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Azure Blob backup support #5674

Merged
merged 8 commits into from
Mar 6, 2020

Conversation

dkhenry
Copy link
Contributor

@dkhenry dkhenry commented Jan 9, 2020

This adds initial support for Azure blob service as a backup target

Closes #3580

@dkhenry dkhenry requested a review from sougou as a code owner January 9, 2020 04:57
@dkhenry dkhenry requested review from enisoc and deepthi January 9, 2020 04:58
deepthi
deepthi previously approved these changes Jan 9, 2020
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Please see note inline.

go/vt/mysqlctl/azblobbackupstorage/azblob.go Show resolved Hide resolved
go/vt/mysqlctl/azblobbackupstorage/azblob.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/azblobbackupstorage/azblob.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/azblobbackupstorage/azblob.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/azblobbackupstorage/azblob.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/azblobbackupstorage/azblob.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/azblobbackupstorage/azblob.go Show resolved Hide resolved
go/vt/mysqlctl/azblobbackupstorage/azblob.go Show resolved Hide resolved
go/vt/mysqlctl/azblobbackupstorage/azblob.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/azblobbackupstorage/azblob.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/azblobbackupstorage/azblob.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/azblobbackupstorage/azblob.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/azblobbackupstorage/azblob.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/azblobbackupstorage/azblob.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/azblobbackupstorage/azblob.go Outdated Show resolved Hide resolved
@deepthi deepthi dismissed their stale review January 13, 2020 01:05

I'll let @enisoc approve once all feedback has been addressed.

@morgo
Copy link
Contributor

morgo commented Feb 6, 2020

@dkhenry ping

Dan Kozlowski added 3 commits March 4, 2020 14:56
This adds initial support for Azure blob service as a backup target

Signed-off-by: Dan Kozlowski <[email protected]>
Giving Env paramaters for secrets, not just CLI.
Rename prefix to be storage_root i.a.w what we do for s3 and gcs

Signed-off-by: Dan Kozlowski <[email protected]>
Signed-off-by: Dan Kozlowski <[email protected]>
@dkhenry dkhenry requested review from enisoc and deepthi March 4, 2020 23:04
Dan Kozlowski and others added 4 commits March 4, 2020 18:53
Copy link
Member

@enisoc enisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FYI I pushed an extra commit with the changes we discussed offline.

@dkhenry dkhenry merged commit f569401 into vitessio:master Mar 6, 2020
@dkhenry dkhenry deleted the dk-add-azblob-backups branch March 6, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Azure Backup Provider
4 participants