Fix master branch #5461
Merged
Fix master branch #5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Tocker <[email protected]>
sougou
approved these changes
Nov 25, 2019
systay
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Vectors: Online DDL support Signed-off-by: Shlomi Noach <[email protected]> * Add support for vectors in vreplication workflows. unit and e2e tests. Update cnf file to add loose_with_ps_vectors Signed-off-by: Rohit Nayak <[email protected]> * Self review fixes. Add e2e TestVector to CI Signed-off-by: Rohit Nayak <[email protected]> * Simplify unit test CI workflow to debug failure Signed-off-by: Rohit Nayak <[email protected]> * Skip test on errors on setting with_ps_vectors Signed-off-by: Rohit Nayak <[email protected]> * Revert debug mods to unit_race.yml Signed-off-by: Rohit Nayak <[email protected]> * Unit test race is again failing with no logs. So modify CI workflow temporarily to get full detail to debug random failures apparently unrelated to this PR Signed-off-by: Rohit Nayak <[email protected]> * Setup templating for vectors vreplication build Signed-off-by: Dirkjan Bussink <[email protected]> * Add vcopier unit test. Insert additional rows in e2e test after copy phase to test replication phase Signed-off-by: Rohit Nayak <[email protected]> * Switch shard for vector test to correct one Signed-off-by: Rohit Nayak <[email protected]> * Use vectors build for unit tests Signed-off-by: Dirkjan Bussink <[email protected]> * Refactor tests: move vector unit tests to separate files Signed-off-by: Rohit Nayak <[email protected]> * endtoend suite: filter with ONLINEDDL_SUITE_TEST_FILTER Signed-off-by: Shlomi Noach <[email protected]> * recognize ERVectorDimensionsMismatch = ErrorCode(4501) as unrecoverable Signed-off-by: Shlomi Noach <[email protected]> * add expected failign vector test. Rename vector tests Signed-off-by: Shlomi Noach <[email protected]> * recognize ERVectorDimensionsMismatch = ErrorCode(4501) as unrecoverable Signed-off-by: Shlomi Noach <[email protected]> * Unit race still failing without details:-(. Commenting out the summary code which seems to be redacting the details Signed-off-by: Rohit Nayak <[email protected]> * 'onlineddl_vrepl_suite' now requires a vectors build Signed-off-by: Shlomi Noach <[email protected]> * use vectors build Signed-off-by: Shlomi Noach <[email protected]> * update mysql version Signed-off-by: Shlomi Noach <[email protected]> --------- Signed-off-by: Shlomi Noach <[email protected]> Signed-off-by: Rohit Nayak <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: Rohit Nayak <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test broke because of the interaction between two PRs: #5346 and #5427
This restores the intended behavior, which is that Vitess does not package etcd and looks for it in the
$PATH.Signed-off-by: Morgan Tocker [email protected]