Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding AllowUnsafeDMLs in vttablet configuration #3941

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Adding AllowUnsafeDMLs in vttablet configuration #3941

merged 1 commit into from
Nov 5, 2018

Conversation

adefilippo83
Copy link

Signed-off-by: Alessandro De Filippo [email protected]

@adefilippo83 adefilippo83 force-pushed the allowdml branch 3 times, most recently from 70a2653 to fa08761 Compare May 17, 2018 15:47
@adefilippo83 adefilippo83 changed the title Adding AllowUnsafeDMLs as option in vttablet config file Adding AllowUnsafeDMLs as vttablet parameter May 17, 2018
@adefilippo83 adefilippo83 changed the title Adding AllowUnsafeDMLs as vttablet parameter Adding AllowUnsafeDMLs in vttablet configuration May 17, 2018
sougou
sougou reviewed May 19, 2018
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@demmer what do you think about PassthroughDMLs also acting as AllowUnsafeDMLs. Is there a situation where we'd want to separate the two?

@sougou
Copy link
Contributor

sougou commented Oct 28, 2018

Can you rebase this and get tests to pass?

@sougou
Copy link
Contributor

sougou commented Nov 4, 2018

@adefilippo83: Can you rebase this old PR? Let's get this submitted.

@adefilippo83 adefilippo83 force-pushed the allowdml branch 6 times, most recently from 6f8e927 to e7268d1 Compare November 5, 2018 00:05
@adefilippo83
Copy link
Author

Hi @sougou: I just rebased and squashed. Waiting for tests to pass.

@sougou sougou merged commit 54855ec into vitessio:master Nov 5, 2018
@rafael rafael mentioned this pull request Dec 3, 2018
Merged
@snyk-bot snyk-bot mentioned this pull request Jul 14, 2021
Open
notfelineit pushed a commit to planetscale/vitess that referenced this pull request Mar 12, 2024
@planetscale-actions-bot @frouioui
[latest-17.0](vitessio#3938): CherryPick(vitessio#14753): Add a retry…
a2c4499 
… to remove the vttablet directory during upgrade/downgrade backup tests (vitessio#3941)

Co-authored-by: Florent Poinsard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adefilippo83 @sougou