Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug makefile build info #2917

Closed
wants to merge 38 commits into from
Closed

Fix bug makefile build info #2917

wants to merge 38 commits into from

Conversation

ameetkotian
Copy link
Contributor

@ameetkotian ameetkotian commented Jun 7, 2017 •
edited
Loading

No description provided.

demmer and others added 30 commits March 17, 2017 16:44
@demmer
Merge pull request #1 from tinyspeck/upstream-update
304fa02 
upstream update
@demmer
remove verbose command and connection logging
449ea49
@demmer
Merge pull request #2 from tinyspeck/quieter-mysqlconn
44bc078 
update to latest and suppress vtgate logging
@demmer
truncate long sql queries in the various vttablet debug UIs
984d475
@demmer
truncate long sql queries when marshalling to json
cdee810
@demmer
add testcase for string truncation in debug output
10f3666
@demmer
truncate long queries in the querylogz debug page
02e08e8
@demmer
Merge pull request #3 from tinyspeck/truncate-long-queries-in-ui
61094af 
update to latest and truncate long queries in ui
Merge branch 'master' of github.com:youtube/vitess into fork_sync
095d7af 
Fixed merge conflict in go/vt/utils/utils.go
@ilmerovingio
Merge pull request #4 from tinyspeck/fork_sync
ca16755 
Update to latest
@demmer
add query truncation in vtgate /debug/query_plans
bd876a5
@demmer
rework TruncateQuery to take the max length as an argument
bbfc8e3
@demmer
add a common option to truncate long queries in errors
db8d206
@demmer
rework error log and debug ui truncation
ada4380 
As per PR feedback, added command line flags to separately control
the maximum length of queries in the UI and in error logs.

Also added additional cases for errors from vtgate.
@demmer
go fmt the new additions
db98695
@demmer
add truncation to tabletserver QueryAsString
d52ede9
@demmer
rework the error string truncation again
ecf16bb 
After testing more cases in the actual deployment I realized that in
several cases we actually have a protobuf object and therefore need to
call fmt.Sprintf to generate the value before truncating the string.
@demmer
move the TruncateFor helpers into the sqlparser package
0ed09e4
@demmer
preserve trailing comments when truncating long queries
7d6591c
@demmer
Merge pull request #5 from tinyspeck/truncate-long-queries-in-logs-sl…
a48acff 
…ack-2

truncate long queries in logs
@demmer
remove unused utils import
f47a2c1
@demmer
Merge pull request #6 from tinyspeck/truncate-long-queries-in-logs-sl…
1e63bf7 
…ack-2

remove unused utils import
@demmer
Revert "Merge pull request #6 from tinyspeck/truncate-long-queries-in…
22162b2 
…-logs-slack-2"

This reverts commit 1e63bf7, reversing
changes made to a48acff.
@demmer
Revert "Merge pull request #5 from tinyspeck/truncate-long-queries-in…
e731052 
…-logs-slack-2"

This reverts commit a48acff, reversing
changes made to ca16755.
@demmer
Merge remote-tracking branch 'origin/master' into slack-update-to-latest
4ae1941
@demmer
Merge pull request #7 from tinyspeck/slack-update-to-latest
2ebe9f2 
update to latest master
@demmer
don't try to roll back on a nonexistent session
8da23a4
@demmer
Merge pull request #8 from tinyspeck/fix-mysql-disconnect-panic-slack
73d1d95 
don't try to roll back on a nonexistent session
Fix roll back on a nonexistent session
1c89514
Merge pull request #9 from tinyspeck/fix_build
1483ca1 
Fix roll back on a nonexistent session
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@ameetkotian ameetkotian closed this Jun 7, 2017
@ameetkotian ameetkotian deleted the fix_bug_makefile_build_info branch June 7, 2017 23:34
@ameetkotian ameetkotian restored the fix_bug_makefile_build_info branch June 7, 2017 23:35
@ameetkotian ameetkotian deleted the fix_bug_makefile_build_info branch June 7, 2017 23:35
@ameetkotian ameetkotian restored the fix_bug_makefile_build_info branch June 7, 2017 23:36
@ameetkotian ameetkotian deleted the fix_bug_makefile_build_info branch June 7, 2017 23:45
frouioui pushed a commit to planetscale/vitess that referenced this pull request Nov 21, 2023
@planetscale-actions-bot @shlomi-noach
[latest-17.0](vitessio#2917): CherryPick(vitessio#13522): BackupShard…
d8fd39a 
…: support incremental backup (vitessio#2920)

* backport of 2917

* resolved conflict

Signed-off-by: Shlomi Noach <[email protected]>

---------

Signed-off-by: Shlomi Noach <[email protected]>
Co-authored-by: Shlomi Noach <[email protected]>
frouioui pushed a commit to planetscale/vitess that referenced this pull request Mar 26, 2024
@planetscale-actions-bot
cherry pick of 13522 (vitessio#2917)
17299db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ameetkotian @googlebot @demmer @ilmerovingio @inexplicable