Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtctl: Added throttler commands. vtworker: Enabled throttler RPC server. #1776

Merged

Conversation

michael-berlin
Copy link
Contributor

@michael-berlin michael-berlin commented Jun 9, 2016

@alainjobart


This change is Reviewable

- Enabled the gRPC throttler client in vtctl and vtctld.
- Added Go test which uses VtctlPipe.
- Added new method RunAndOutput to VtctlPipe which allows to check the output of a command.
- Enabled throttler in resharding.py and check the vtctl commands there as well.
Added a test in worker.py to verify that it's working.
It is required for the vtctl throttler commands.
@alainjobart
Copy link
Contributor

alainjobart commented Jun 9, 2016

:lgtm: You probably want to re-generate the vtctl doc, make sure that works. 'python vtctl_go_reference.py' in doc sub-directory.

Previously, michael-berlin (Michael Berlin) wrote…

vtctl: Added throttler commands. vtworker: Enabled throttler RPC server.

@alainjobart


Reviewed 13 of 13 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Approved with PullApprove

@michael-berlin michael-berlin merged commit 5f98e05 into vitessio:master Jun 10, 2016
@michael-berlin michael-berlin deleted the vtctl_throttler_vtctl_cmds branch June 10, 2016 01:01
frouioui added a commit to planetscale/vitess that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants