-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetTransactionInfo in VTadmin API and page #17142
Add GetTransactionInfo in VTadmin API and page #17142
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17142 +/- ##
==========================================
- Coverage 67.33% 67.32% -0.02%
==========================================
Files 1569 1569
Lines 252476 252502 +26
==========================================
- Hits 170008 169996 -12
- Misses 82468 82506 +38 ☔ View full report in Codecov by Sentry. |
82f9625
to
3c9fb2c
Compare
The screenshot above have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment!
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
e1549cd
to
7d88ebc
Compare
Thank you for the reviews! I have fixed up all the comments and also the parsing of time. We were passing it in in nanoseconds, but the dayjs was expecting it to be in seconds. I have fixed this now. |
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Renan Rangel <[email protected]>
Description
This PR adds a VTAdmin API for getting the transaction information added in #17131. This PR should be merged after it is #17131.
This PR also adds a page to display the following page -
Related Issue(s)
Checklist
Deployment Notes