-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-21.0] [Direct PR] Add RPC to read the reparent journal position #16982
Merged
rohit-nayak-ps
merged 1 commit into
vitessio:release-21.0
from
planetscale:reparent-journal-rpc
Oct 18, 2024
Merged
[release-21.0] [Direct PR] Add RPC to read the reparent journal position #16982
rohit-nayak-ps
merged 1 commit into
vitessio:release-21.0
from
planetscale:reparent-journal-rpc
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Cluster management
labels
Oct 17, 2024
GuptaManan100
requested review from
deepthi,
harshit-gangal,
mattlord,
ajm188,
rohit-nayak-ps,
shlomi-noach and
notfelineit
as code owners
October 17, 2024 04:53
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Oct 17, 2024
GuptaManan100
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Oct 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-21.0 #16982 +/- ##
================================================
- Coverage 69.43% 69.41% -0.03%
================================================
Files 1570 1570
Lines 203841 203889 +48
================================================
- Hits 141547 141536 -11
- Misses 62294 62353 +59 ☔ View full report in Codecov by Sentry. |
57 tasks
rohit-nayak-ps
changed the title
Add RPC to read the reparent journal position
[release-21.0] [DirectPR] Add RPC to read the reparent journal position
Oct 17, 2024
rohit-nayak-ps
changed the title
[release-21.0] [DirectPR] Add RPC to read the reparent journal position
[release-21.0] [Direct PR] Add RPC to read the reparent journal position
Oct 17, 2024
mattlord
approved these changes
Oct 17, 2024
deepthi
approved these changes
Oct 17, 2024
rohit-nayak-ps
merged commit Oct 18, 2024
3fce8ca
into
vitessio:release-21.0
109 of 113 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Cluster management
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an RPC to read the reparent journal information. It is required for the PR #16926 to work well in release-22.0
Related Issue(s)
Checklist
Deployment Notes