-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release 21.0] [Direct PR] Conclude txn in VTAdmin and GetUnresolvedTransactions
bug fix
#16949
Merged
rohit-nayak-ps
merged 1 commit into
vitessio:release-21.0
from
planetscale:vtadmin-fix-distributed-transaction
Oct 14, 2024
Merged
[Release 21.0] [Direct PR] Conclude txn in VTAdmin and GetUnresolvedTransactions
bug fix
#16949
rohit-nayak-ps
merged 1 commit into
vitessio:release-21.0
from
planetscale:vtadmin-fix-distributed-transaction
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuptaManan100
added
Type: Bug
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Query Serving
Component: VTAdmin
VTadmin interface
Backport
This is a backport
labels
Oct 14, 2024
GuptaManan100
requested review from
deepthi,
harshit-gangal,
mattlord,
ajm188,
notfelineit and
rohit-nayak-ps
as code owners
October 14, 2024 15:47
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
…transactions Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
force-pushed
the
vtadmin-fix-distributed-transaction
branch
from
October 14, 2024 15:54
7e4eb9f
to
c2473e2
Compare
deepthi
reviewed
Oct 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-21.0 #16949 +/- ##
=============================================
Coverage 69.42% 69.43%
=============================================
Files 1570 1570
Lines 203814 203841 +27
=============================================
+ Hits 141506 141529 +23
- Misses 62308 62312 +4 ☔ View full report in Codecov by Sentry. |
harshit-gangal
approved these changes
Oct 14, 2024
rohit-nayak-ps
changed the title
Conclude txn in VTAdmin and
[Release 21.0] [Direct PR] Conclude txn in VTAdmin and Oct 14, 2024
GetUnresolvedTransactions
bug fixGetUnresolvedTransactions
bug fix
frouioui
approved these changes
Oct 14, 2024
rohit-nayak-ps
merged commit Oct 14, 2024
40ede99
into
vitessio:release-21.0
100 of 101 checks passed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport
This is a backport
Component: Query Serving
Component: VTAdmin
VTadmin interface
Type: Bug
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does 2 things -
GetUnresolvedTransactions
wherein we don't show the complete list of participants, but omit the metadata manager shard.I will forward port the bug fix against main. This PR is done directly so that it makes it into the RC planned tomorrow.
Related Issue(s)
Checklist
Deployment Notes