Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 21.0] [Direct PR] Conclude txn in VTAdmin and GetUnresolvedTransactions bug fix #16949

Conversation

GuptaManan100
Copy link
Member

Description

This PR does 2 things -

  1. It backports VTAdmin: Support for conclude txn and abandon age param #16834 to release-21 since it has been deemed to be a feature that is required for atomic transactions.
  2. It fixes the bug in GetUnresolvedTransactions wherein we don't show the complete list of participants, but omit the metadata manager shard.

I will forward port the bug fix against main. This PR is done directly so that it makes it into the RC planned tomorrow.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100 GuptaManan100 added Type: Bug Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving Component: VTAdmin VTadmin interface Backport This is a backport labels Oct 14, 2024
Copy link
Contributor

vitess-bot bot commented Oct 14, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v21.0.0 milestone Oct 14, 2024
@vitess-bot vitess-bot mentioned this pull request Oct 14, 2024
35 tasks
@GuptaManan100 GuptaManan100 force-pushed the vtadmin-fix-distributed-transaction branch from 7e4eb9f to c2473e2 Compare October 14, 2024 15:54
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 35 lines in your changes missing coverage. Please review.

Project coverage is 69.43%. Comparing base (34df88f) to head (c2473e2).
Report is 2 commits behind head on release-21.0.

Files with missing lines Patch % Lines
go/vt/vtadmin/api.go 6.66% 14 Missing ⚠️
go/vt/vtadmin/http/transactions.go 0.00% 12 Missing ⚠️
go/vt/vtadmin/http/request.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release-21.0   #16949   +/-   ##
=============================================
  Coverage         69.42%   69.43%           
=============================================
  Files              1570     1570           
  Lines            203814   203841   +27     
=============================================
+ Hits             141506   141529   +23     
- Misses            62308    62312    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohit-nayak-ps rohit-nayak-ps changed the title Conclude txn in VTAdmin and GetUnresolvedTransactions bug fix [Release 21.0] [Direct PR] Conclude txn in VTAdmin and GetUnresolvedTransactions bug fix Oct 14, 2024
@rohit-nayak-ps rohit-nayak-ps merged commit 40ede99 into vitessio:release-21.0 Oct 14, 2024
100 of 101 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the vtadmin-fix-distributed-transaction branch October 14, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport This is a backport Component: Query Serving Component: VTAdmin VTadmin interface Type: Bug Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants