Use go-version-file: go.mod in CI

[timvaillancourt]

Description

This PR uses go-version-file: go.mod in CI that requires a go version == go.mod. This makes the repo a bit easier to maintain in places

The only CI files that still have a specific go-version: set are:

• .github/workflows/upgrade_downgrade_test_backups_e2e.yml
• .github/workflows/upgrade_downgrade_test_backups_manual.yml
• .github/workflows/upgrade_downgrade_test_onlineddl_flow.yml
• .github/workflows/upgrade_downgrade_test_query_serving_queries.yml
• .github/workflows/upgrade_downgrade_test_query_serving_schema.yml
• .github/workflows/upgrade_downgrade_test_reparent_old_vtctl.yml
• .github/workflows/upgrade_downgrade_test_reparent_old_vttablet.yml
• .github/workflows/upgrade_downgrade_test_semi_sync.yml

Are those set by hand? On main these are set to 1.22.7, a previous-release go version. Also I'm unclear if I've broken go-upgrade (I didn't know about this) and could use a hand validating that part 🤔

Example of go-version-file: go.mod finding 1.23.1 (from this PR CI):

Related Issue(s)

#16842

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.45%. Comparing base (969e018) to head (f8a3984).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16841      +/-   ##
==========================================
+ Coverage   69.41%   69.45%   +0.03%     
==========================================
  Files        1570     1570              
  Lines      202945   202923      -22     
==========================================
+ Hits       140880   140940      +60     
+ Misses      62065    61983      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mattlord]

Nice! Thanks, @timvaillancourt !

@frouioui can you also please take a look?

[systay]

👏 Very nice!

[frouioui]

@frouioui can you also please take a look?

I will take a look at the go-upgrade in the morning

[frouioui]

Are those set by hand?

Yes, these match the golang version used on the previous release branch. Since the goal of these workflows is to downgrade from main to the latest release branch, we use the go version found there.

[frouioui]

Left one comment that should be addressed, otherwise that's awesome! 🚀

[timvaillancourt]

Re-requesting review on last tweak from @frouioui 🙇

[frouioui]

LGTM! ❤️