-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vexplain trace
#16768
Add vexplain trace
#16768
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16768 +/- ##
=======================================
Coverage 68.92% 68.92%
=======================================
Files 1566 1566
Lines 201886 201983 +97
=======================================
+ Hits 139149 139222 +73
- Misses 62737 62761 +24 ☔ View full report in Codecov by Sentry. |
83d753f
to
05bf153
Compare
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
05bf153
to
52e8961
Compare
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extra logging incase of retry. As this is recorded for testing in a controlled way, can be ignored.
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>
Description
This PR introduces a new
vexplain trace
command that enhances query analysis by tracking data flow between operators during query execution. Instead of returning the normal results from a query,vexplain trace
provides an execution plan with detailed runtime statistics, including:Example
Here is the output of that query:
Motivation
Understanding the internal workings of query execution is crucial for performance tuning and optimization. While traditional
VEXPLAIN
commands show the planned execution path, they lack runtime statistics. Thevexplain trace
command fills this gap by providing real-time data flow information, allowing for deeper insights into query performance and helping to identify bottlenecks more effectively.Checklist