Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vexplain trace #16768

Merged
merged 11 commits into from
Sep 17, 2024
Merged

Add vexplain trace #16768

merged 11 commits into from
Sep 17, 2024

Conversation

systay
Copy link
Collaborator

@systay systay commented Sep 12, 2024

Description

This PR introduces a new vexplain trace command that enhances query analysis by tracking data flow between operators during query execution. Instead of returning the normal results from a query, vexplain trace provides an execution plan with detailed runtime statistics, including:

  • NoOfCalls: The number of times each operator was invoked during query execution.
  • AvgNumberOfRows: The average number of rows returned per call for each operator.
  • MedianNumberOfRows: The median number of rows returned per call for each operator.

Example

-- Example query
VEXPLAIN TRACE SELECT
    o.o_orderpriority,
    EXTRACT(YEAR FROM o.o_orderdate) AS order_year,
    COUNT(DISTINCT o.o_orderkey) AS order_count,
    SUM(l.l_extendedprice * (1 - l.l_discount)) AS total_revenue
FROM
    orders o
JOIN
    lineitem l ON o.o_orderkey > l.l_orderkey
WHERE
    o.o_orderdate BETWEEN '1995-01-01' AND '1996-12-31'
GROUP BY
    o.o_orderpriority,
    EXTRACT(YEAR FROM o.o_orderdate)
ORDER BY
    o.o_orderpriority,
    order_year

Here is the output of that query:

{
    "OperatorType": "Aggregate",
    "Variant": "Ordered",
    "NoOfCalls": 1,
    "AvgNumberOfRows": 10,
    "MedianNumberOfRows": 10,
    // ... other fields ...
    "Inputs": [
        {
            "OperatorType": "Sort",
            "Variant": "Memory",
            "NoOfCalls": 1,
            "AvgNumberOfRows": 1995,
            "MedianNumberOfRows": 1995,
            // ... other fields ...
            "Inputs": [
                {
                    "OperatorType": "Route",
                    "Variant": "Scatter",
                    "NoOfCalls": 2,
                    "AvgNumberOfRows": 1000,
                    "MedianNumberOfRows": 1000,
                    // ... other fields ...
                },
                {
                    "OperatorType": "Route",
                    "Variant": "Scatter",
                    "NoOfCalls": 2000,
                    "AvgNumberOfRows": 1.995,
                    "MedianNumberOfRows": 2,
                    // ... other fields ...
                }
            ]
        }
    ]
}

Motivation

Understanding the internal workings of query execution is crucial for performance tuning and optimization. While traditional VEXPLAIN commands show the planned execution path, they lack runtime statistics. The vexplain trace command fills this gap by providing real-time data flow information, allowing for deeper insights into query performance and helping to identify bottlenecks more effectively.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Sep 12, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 12, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 76.37795% with 30 lines in your changes missing coverage. Please review.

Project coverage is 68.92%. Comparing base (f97ea77) to head (40b1edd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtgate/engine/vexplain.go 68.33% 19 Missing ⚠️
go/vt/vtgate/vcursor_impl.go 76.00% 6 Missing ⚠️
go/vt/vtgate/engine/plan_description.go 85.18% 4 Missing ⚠️
go/vt/vtgate/planbuilder/vexplain.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16768   +/-   ##
=======================================
  Coverage   68.92%   68.92%           
=======================================
  Files        1566     1566           
  Lines      201886   201983   +97     
=======================================
+ Hits       139149   139222   +73     
- Misses      62737    62761   +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Sep 13, 2024
@systay systay changed the title vexplain trace Add vexplain trace Sep 13, 2024
@systay systay mentioned this pull request Sep 15, 2024
5 tasks
systay and others added 6 commits September 15, 2024 07:54
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra logging incase of retry. As this is recorded for testing in a controlled way, can be ignored.

@harshit-gangal harshit-gangal merged commit 8816a2d into vitessio:main Sep 17, 2024
97 checks passed
@harshit-gangal harshit-gangal deleted the vexplain-trace branch September 17, 2024 13:11
systay added a commit that referenced this pull request Sep 20, 2024
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants