-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTAdmin(web): Some tweaks in the workflow details #16706
VTAdmin(web): Some tweaks in the workflow details #16706
Conversation
Signed-off-by: Noble Mittal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Noble Mittal <[email protected]>
bca4b0f
to
346bdad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you removed the Streams from the Lag tab, we can remove the Scroll To Streams link.
Done. Also, pushed the changes to show "Scroll To Streams" only in case of Details Tab. |
Signed-off-by: Noble Mittal <[email protected]>
85eb8e1
to
42bb303
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Just a couple of minor nits/questions. VTAdmin is looking so useful now for VReplication workflows! I love it.
/> | ||
</div> | ||
))} | ||
{streams.length <= 8 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we should have some sort of else condition here where we display something to indicate that we've elided the otherwise expected UI element / display content due to the larger number of shards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ling space Signed-off-by: Noble Mittal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16706 +/- ##
==========================================
+ Coverage 68.91% 68.93% +0.02%
==========================================
Files 1565 1565
Lines 201605 201745 +140
==========================================
+ Hits 138926 139067 +141
+ Misses 62679 62678 -1 ☔ View full report in Codecov by Sentry. |
Description
Some changes to the
Workflow
screen:Streams
Table from the Lag Graph tabRelated Issue(s)
Screenshots
Checklist