Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VDiff: Improve row diff handling in report #16618

Merged
merged 10 commits into from
Aug 27, 2024
Merged

VDiff: Improve row diff handling in report #16618

merged 10 commits into from
Aug 27, 2024

Commits on Aug 20, 2024

  1. Improve sample row diffs in report 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    48c5e48 View commit details
    Browse the repository at this point in the history

  2. Add flag to control truncate point 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3253b09 View commit details
    Browse the repository at this point in the history

  3. Add unit test 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    aac9f0e View commit details
    Browse the repository at this point in the history

  4. Deflake unit tests 

    I was seeing occasional panics with:

panic: close of closed channel
goroutine XXX [running]:
vitess.io/vitess/go/vt/binlog/binlogplayer.(*MockDBClient).ExecuteFetch(0xc000282070, {0xc00005d020, 0x24}, 0x1?)

Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    e3cb05d View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into vdiff_rowdiff_truncation 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    56ef500 View commit details
    Browse the repository at this point in the history

  6. Changes after self review 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f98d261 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Single allocation 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7e8f008 View commit details
    Browse the repository at this point in the history

  2. Improve examples 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4bc3b99 View commit details
    Browse the repository at this point in the history

  3. Don't need auto-retry as it is default 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    5652c6f View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into vdiff_rowdiff_truncation 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    a9117da View commit details
    Browse the repository at this point in the history