-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vttablet api distributed transaction changes #16506
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jul 30, 2024
harshit-gangal
force-pushed
the
tx-idempotent
branch
from
July 30, 2024 16:56
ffb90d5
to
4f0d8bd
Compare
harshit-gangal
added
Type: Feature
Component: Query Serving
and removed
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jul 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16506 +/- ##
==========================================
+ Coverage 68.74% 68.76% +0.01%
==========================================
Files 1556 1556
Lines 199705 199715 +10
==========================================
+ Hits 137292 137334 +42
+ Misses 62413 62381 -32 ☔ View full report in Codecov by Sentry. |
…ection, log warn on failing to commit a prepare transaction, fail to accept a commit on MM Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
force-pushed
the
tx-idempotent
branch
from
August 6, 2024 09:54
4f0d8bd
to
bf89751
Compare
harshit-gangal
removed
the
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
label
Aug 6, 2024
harshit-gangal
requested review from
systay,
shlomi-noach,
rohit-nayak-ps,
timvaillancourt,
frouioui and
GuptaManan100
as code owners
August 6, 2024 10:19
systay
approved these changes
Aug 6, 2024
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
force-pushed
the
tx-idempotent
branch
from
August 6, 2024 14:55
5e81dc6
to
911e526
Compare
Signed-off-by: Harshit Gangal <[email protected]>
GuptaManan100
approved these changes
Aug 7, 2024
venkatraju
pushed a commit
to slackhq/vitess
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Harshit Gangal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR make few changes to the distributed transactions API on the vttablet
Related Issue(s)
Checklist
Deployment Notes