-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builtinbackup: log during restore as restore, not as backup #16483
Conversation
Signed-off-by: deepthi <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I only had a couple of nits that you can resolve as you feel best.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16483 +/- ##
==========================================
- Coverage 68.64% 68.62% -0.02%
==========================================
Files 1551 1551
Lines 199471 199474 +3
==========================================
- Hits 136925 136889 -36
- Misses 62546 62585 +39 ☔ View full report in Codecov by Sentry. |
Signed-off-by: deepthi <[email protected]>
…#16483) Signed-off-by: deepthi <[email protected]>
Description
Parameterize the
ReportProgress
function which is being used by both backup and restore so that we log properly.Related Issue(s)
Fixes #16482
Checklist
Deployment Notes