Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtinbackup: log during restore as restore, not as backup #16483

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Jul 25, 2024

Description

Parameterize the ReportProgress function which is being used by both backup and restore so that we log properly.

Related Issue(s)

Fixes #16482

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@deepthi deepthi requested a review from mattlord as a code owner July 25, 2024 23:57
Copy link
Contributor

vitess-bot bot commented Jul 25, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 25, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jul 25, 2024
@deepthi deepthi removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 25, 2024
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I only had a couple of nits that you can resolve as you feel best.

go/vt/mysqlctl/builtinbackupengine.go Show resolved Hide resolved
go/vt/mysqlctl/builtinbackupengine.go Outdated Show resolved Hide resolved
go/vt/mysqlctl/builtinbackupengine.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.62%. Comparing base (59408f9) to head (47b3fb5).

Files Patch % Lines
go/vt/mysqlctl/builtinbackupengine.go 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16483      +/-   ##
==========================================
- Coverage   68.64%   68.62%   -0.02%     
==========================================
  Files        1551     1551              
  Lines      199471   199474       +3     
==========================================
- Hits       136925   136889      -36     
- Misses      62546    62585      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: deepthi <[email protected]>
@deepthi deepthi removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Jul 26, 2024
@deepthi deepthi merged commit 373cf34 into vitessio:main Jul 26, 2024
130 checks passed
@deepthi deepthi deleted the ds-fix-restore-logging branch July 26, 2024 16:36
venkatraju pushed a commit to slackhq/vitess that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: incorrect logging from restoring a backup
5 participants