Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small internal cleanups #16467

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

dbussink
Copy link
Contributor

This cleans up some logic around the default collation and coercion. We now make the MySQL 8 collations the default if there's no version mismatch instead of what we had with MySQL 5.7.

Additionally we fix a small issue that doesn't really matter in practice with an unknown collation, but we know have a full type so we do know it, so let's use it.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

This cleans up some logic around the default collation and coercion. We
now make the MySQL 8 collations the default if there's no version
mismatch instead of what we had with MySQL 5.7.

Additionally we fix a small issue that doesn't really matter in
practice with an unknown collation, but we know have a full type so we
do know it, so let's use it.

Signed-off-by: Dirkjan Bussink <[email protected]>
Copy link
Contributor

vitess-bot bot commented Jul 23, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 23, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jul 23, 2024
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.65%. Comparing base (ae7214d) to head (27cd8f9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16467   +/-   ##
=======================================
  Coverage   68.64%   68.65%           
=======================================
  Files        1549     1549           
  Lines      199214   199212    -2     
=======================================
+ Hits       136750   136762   +12     
+ Misses      62464    62450   -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Dirkjan Bussink <[email protected]>
@vmg vmg merged commit 4bf9c34 into vitessio:main Jul 24, 2024
127 checks passed
@vmg vmg deleted the dbussink/small-cleanups branch July 24, 2024 08:27
venkatraju pushed a commit to slackhq/vitess that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants