-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small internal cleanups #16467
Merged
Merged
Small internal cleanups #16467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up some logic around the default collation and coercion. We now make the MySQL 8 collations the default if there's no version mismatch instead of what we had with MySQL 5.7. Additionally we fix a small issue that doesn't really matter in practice with an unknown collation, but we know have a full type so we do know it, so let's use it. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
requested review from
harshit-gangal,
systay,
frouioui,
GuptaManan100 and
mattlord
as code owners
July 23, 2024 13:46
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jul 23, 2024
dbussink
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jul 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16467 +/- ##
=======================================
Coverage 68.64% 68.65%
=======================================
Files 1549 1549
Lines 199214 199212 -2
=======================================
+ Hits 136750 136762 +12
+ Misses 62464 62450 -14 ☔ View full report in Codecov by Sentry. |
frouioui
approved these changes
Jul 23, 2024
Signed-off-by: Dirkjan Bussink <[email protected]>
vmg
approved these changes
Jul 24, 2024
venkatraju
pushed a commit
to slackhq/vitess
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Dirkjan Bussink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some logic around the default collation and coercion. We now make the MySQL 8 collations the default if there's no version mismatch instead of what we had with MySQL 5.7.
Additionally we fix a small issue that doesn't really matter in practice with an unknown collation, but we know have a full type so we do know it, so let's use it.
Checklist