-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some unused MySQL 5.6 code #16465
Remove some unused MySQL 5.6 code #16465
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16465 +/- ##
==========================================
- Coverage 68.65% 68.65% -0.01%
==========================================
Files 1550 1550
Lines 199412 199410 -2
==========================================
- Hits 136900 136896 -4
- Misses 62512 62514 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be rebased now that the PR was merged to add unit testing on MySQL 8.4.
Signed-off-by: Graham Campbell <[email protected]>
ee575e9
to
2e1ea2b
Compare
Rebased and updated commit to signed-off version. |
Signed-off-by: Graham Campbell <[email protected]>
Description
Removes some unused MySQL 5.6 code. Usage of
MySQLJSONFlavorCapability
was already removed some time ago, but the capability was left in. I also noticed some stuff for collations and binlog, but I left that alone (at least for this PR).Related Issue(s)
Checklist
Deployment Notes