Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schemadiff: Online DDL support, declarative based #16462

Merged
merged 10 commits into from
Jul 30, 2024
Merged

schemadiff: Online DDL support, declarative based #16462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bcf7b3e
schemadiff: Online DDL support, table diff analysis, ALTER TABLE anal…
shlomi-noach Jul 23, 2024
39968d7
variable name typo
shlomi-noach Jul 23, 2024
2ee6545
fix ordinal value
shlomi-noach Jul 24, 2024
7583c14
Add tests
shlomi-noach Jul 24, 2024
6a7018e
Support NewCreateViewEntityFromSQL()
shlomi-noach Jul 24, 2024
9e274ba
Merge branch 'main' into schemadiff-onlineddl-analysis
shlomi-noach Jul 24, 2024
4c21d55
typo
shlomi-noach Jul 30, 2024
0f89131
preallocate
shlomi-noach Jul 30, 2024
17fa02a
fix licenses
shlomi-noach Jul 30, 2024
dbd20de
resolved conflict
shlomi-noach Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go/test/endtoend/onlineddl/vrepl_suite/onlineddl_vrepl_suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ const (
testFilterEnvVar = "ONLINEDDL_SUITE_TEST_FILTER"
)

// Use $VREPL_SUITE_TEST_FILTER environment variable to filter tests by name.
func TestMain(m *testing.M) {
defer cluster.PanicHandler(nil)
flag.Parse()
Expand Down
2 changes: 1 addition & 1 deletion ...st/endtoend/onlineddl/vrepl_suite/testdata/fail-different-pk-new-pk-column/expect_failure
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Found no possible
found no possible
2 changes: 1 addition & 1 deletion go/test/endtoend/onlineddl/vrepl_suite/testdata/fail-drop-pk/expect_failure
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Found no possible
found no possible
2 changes: 1 addition & 1 deletion go/test/endtoend/onlineddl/vrepl_suite/testdata/fail-float-unique-key/create.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
drop table if exists onlineddl_test;
create table onlineddl_test (
f float,
f float not null,
i int not null,
ts timestamp default current_timestamp,
dt datetime,
Expand Down
2 changes: 1 addition & 1 deletion go/test/endtoend/onlineddl/vrepl_suite/testdata/fail-float-unique-key/expect_failure
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Found no possible
found no possible
2 changes: 1 addition & 1 deletion go/test/endtoend/onlineddl/vrepl_suite/testdata/fail-no-unique-key/expect_failure
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Found no possible
found no possible
1 change: 1 addition & 0 deletions go/test/endtoend/onlineddl/vrepl_suite/testdata/fail-nullable-unique-key/alter
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
add column v varchar(32)
11 changes: 11 additions & 0 deletions go/test/endtoend/onlineddl/vrepl_suite/testdata/fail-nullable-unique-key/create.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
drop table if exists onlineddl_test;
create table onlineddl_test (
id int,
i int not null,
ts timestamp default current_timestamp,
dt datetime,
key i_idx(i),
unique key id_uidx(id)
) auto_increment=1;

drop event if exists onlineddl_test;
1 change: 1 addition & 0 deletions go/test/endtoend/onlineddl/vrepl_suite/testdata/fail-nullable-unique-key/expect_failure
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
found no possible
16 changes: 2 additions & 14 deletions go/vt/schemadiff/capability.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,6 @@ func alterOptionCapableOfInstantDDL(alterOption sqlparser.AlterOption, createTab
}
}

isGeneratedColumn := func(col *sqlparser.ColumnDefinition) (bool, sqlparser.ColumnStorage) {
if col == nil {
return false, 0
}
if col.Type.Options == nil {
return false, 0
}
if col.Type.Options.As == nil {
return false, 0
}
return true, col.Type.Options.Storage
}
colStringStrippedDown := func(col *sqlparser.ColumnDefinition, stripEnum bool) string {
strippedCol := sqlparser.Clone(col)
// strip `default`
Expand Down Expand Up @@ -153,7 +141,7 @@ func alterOptionCapableOfInstantDDL(alterOption sqlparser.AlterOption, createTab
return false, nil
}
for _, column := range opt.Columns {
if isGenerated, storage := isGeneratedColumn(column); isGenerated {
if isGenerated, storage := IsGeneratedColumn(column); isGenerated {
if storage == sqlparser.StoredStorage {
// Adding a generated "STORED" column is unsupported
return false, nil
Expand Down Expand Up @@ -188,7 +176,7 @@ func alterOptionCapableOfInstantDDL(alterOption sqlparser.AlterOption, createTab
// not supported if the column is part of an index
return false, nil
}
if isGenerated, _ := isGeneratedColumn(col); isGenerated {
if isGenerated, _ := IsGeneratedColumn(col); isGenerated {
// supported by all 8.0 versions
// Note: according to the docs dropping a STORED generated column is not INSTANT-able,
// but in practice this is supported. This is why we don't test for STORED here, like
Expand Down
Loading
Loading