Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the Golang Dependencies #16379

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Upgrade the Golang Dependencies #16379

merged 1 commit into from
Jul 15, 2024

Conversation

vitess-bot
Copy link
Contributor

This Pull Request updates all the Golang dependencies to their latest version using go get -u ./....

cc @vitessio/release

@frouioui
upgrade go deps
c8a7ab0 
Signed-off-by: GitHub <[email protected]>
@vitess-bot vitess-bot requested a review from ajm188 as a code owner July 15, 2024 00:16
@vitess-bot vitess-bot added Component: General Changes throughout the code base go Type: Dependencies Dependency updates labels Jul 15, 2024
@vitess-bot vitess-bot requested a review from a team July 15, 2024 00:16
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 15, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 15, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jul 15, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.69%. Comparing base (3d36adb) to head (c8a7ab0).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16379      +/-   ##
==========================================
+ Coverage   68.66%   68.69%   +0.03%     
==========================================
  Files        1548     1548              
  Lines      199083   199083              
==========================================
+ Hits       136694   136769      +75     
+ Misses      62389    62314      -75

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 15, 2024
@frouioui frouioui merged commit 2e009e3 into main Jul 15, 2024
220 of 228 checks passed
@frouioui frouioui deleted the upgrade-go-deps-on-main branch July 15, 2024 16:55
systay pushed a commit that referenced this pull request Jul 22, 2024
@planetscale-actions-bot @frouioui
CherryPick(#16379): Upgrade the Golang Dependencies (#5633)
d95ea45 
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
venkatraju pushed a commit to slackhq/vitess that referenced this pull request Aug 29, 2024
@vitess-bot @frouioui @venkatraju
Upgrade the Golang Dependencies (vitessio#16379)
fda9e1b 
Signed-off-by: GitHub <[email protected]>
Co-authored-by: frouioui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@notfelineit notfelineit notfelineit approved these changes

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: General Changes throughout the code base go Type: Dependencies Dependency updates
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vitess-bot @notfelineit @frouioui