-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note on QueryCacheHits
and QueryCacheMisses
in the release notes
#16299
Merged
frouioui
merged 1 commit into
vitessio:main
from
planetscale:edit-v20-metrics-release-notes
Jul 1, 2024
Merged
Add a note on QueryCacheHits
and QueryCacheMisses
in the release notes
#16299
frouioui
merged 1 commit into
vitessio:main
from
planetscale:edit-v20-metrics-release-notes
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
requested review from
harshit-gangal,
systay and
shlomi-noach
as code owners
June 28, 2024 21:42
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
frouioui
requested review from
rohit-nayak-ps,
timvaillancourt and
deepthi
as code owners
June 28, 2024 21:43
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jun 28, 2024
frouioui
added
Type: Internal Cleanup
Component: Observability
Pull requests that touch tracing/metrics/monitoring
Component: Documentation
docs related issues/PRs
Backport to: release-20.0
Needs to be backport to release-20.0
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jun 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16299 +/- ##
==========================================
- Coverage 68.71% 68.70% -0.01%
==========================================
Files 1544 1544
Lines 198011 198011
==========================================
- Hits 136064 136051 -13
- Misses 61947 61960 +13 ☔ View full report in Codecov by Sentry. |
notfelineit
approved these changes
Jul 1, 2024
rohit-nayak-ps
approved these changes
Jul 1, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
…notes (#16299) Signed-off-by: Florent Poinsard <[email protected]>
frouioui
pushed a commit
that referenced
this pull request
Jul 1, 2024
…in the release notes (#16299) (#16306) Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-20.0
Needs to be backport to release-20.0
Component: Documentation
docs related issues/PRs
Component: Observability
Pull requests that touch tracing/metrics/monitoring
Type: Internal Cleanup
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the v20 release notes to mention that
QueryCacheXX
does not refer to an actual query cache but rather to a query plan cache.The metrics will be renamed in v21 through #16289.
Let's backport this to v20 for the release notes.
Related Issue(s)