-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlparser: Remove unneeded escaping #16255
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
It's not necessary to escape a double quote since we quote everything with single quotes. This removes a lot of escaping noise, especially around JSON usage. Signed-off-by: Dirkjan Bussink <[email protected]>
ac6f641
to
4ce25bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in principal, we just need to see if there are any test failures.
Signed-off-by: Dirkjan Bussink <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16255 +/- ##
==========================================
+ Coverage 68.58% 68.61% +0.02%
==========================================
Files 1544 1544
Lines 197984 197991 +7
==========================================
+ Hits 135795 135856 +61
+ Misses 62189 62135 -54 ☔ View full report in Codecov by Sentry. |
It's not necessary to escape a double quote since we quote everything with single quotes. This removes a lot of escaping noise, especially around JSON usage.
Checklist