Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-19.0] Fix vtgate crash in group concat #16254

Merged
merged 1 commit into from
Jun 24, 2024
Merged

[release-19.0] Fix vtgate crash in group concat #16254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/aggregation_pushing_helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@
case opcode.AggregateGroupConcat:
f := aggr.Func.(*sqlparser.GroupConcatExpr)
if f.Distinct || len(f.OrderBy) > 0 || f.Separator != "" {
panic("fail here")
panic(vterrors.VT12001("cannot evaluate group concat with distinct, order by or a separator"))

Check warning on line 138 in go/vt/vtgate/planbuilder/operators/aggregation_pushing_helper.go

View check run for this annotation

Codecov / codecov/patch

go/vt/vtgate/planbuilder/operators/aggregation_pushing_helper.go#L138 

Added line #L138 was not covered by tests
}
// this needs special handling, currently aborting the push of function
// and later will try pushing the column instead.
Expand Down
Loading