-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-20.0-rc] Fix vtgate crash in group concat #16253
[release-20.0-rc] Fix vtgate crash in group concat #16253
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-20.0-rc #16253 +/- ##
===================================================
+ Coverage 68.52% 68.53% +0.01%
===================================================
Files 1541 1541
Lines 197788 197788
===================================================
+ Hits 135525 135550 +25
+ Misses 62263 62238 -25 ☔ View full report in Codecov by Sentry. |
If this does hit the RC branch, doesn't this mean the 20.0.0 release is necessarily delayed, because an RC3 will be needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we merge this we must do an RC-3.
I don't think we should do a new RC based on this. It's an old issue that's been in many releases in the past. |
Should we close this PR then? |
If this PR signals the release of a new RC, we should close it. |
Description
This PR only backports the vtgate crash fix from #16237.
Related Issue(s)
Group_concat
with separator crashes vtgate during planning #16238Checklist
Deployment Notes