Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make the arguments print themselves with type info #16232

Merged
merged 19 commits into from
Jun 27, 2024

Conversation

systay
Copy link
Collaborator

@systay systay commented Jun 19, 2024

Description

Currently, arguments are sent as a map to the vttablet, which then incorporates them into the query string using literals. This method works well for types with robust literal support but poses issues for types that do not, such as dates and times.

This PR addresses the issue by altering the handling of types that cannot be easily represented as literals. For these types, we will now use strings and the CAST function to convert them into the correct type within the query, ensuring the values are correctly interpreted by the database.

Example:

The query that triggered this work was:

select (select sum(length(foo)) from tbl1) as X from tbl2

This would be split up into two different queries:

select sum(length(foo)) from tbl1;

# and the second query

select :sq1 as X from tbl2

If the first query returns a decimal value of 50, the second query becomes:

select 50 as X from tbl2

This converts the value to a bigint, not a decimal, which is unexpected.

Related Issue(s)

Fixes #16261

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Jun 19, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 19, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jun 19, 2024
@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 25, 2024
go/vt/sqlparser/ast_format.go Outdated Show resolved Hide resolved
go/vt/sqlparser/ast_format.go Outdated Show resolved Hide resolved
@deepthi deepthi added the NeedsIssue A linked issue is missing for this Pull Request label Jun 25, 2024
Signed-off-by: Florent Poinsard <[email protected]>
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 51.51515% with 48 lines in your changes missing coverage. Please review.

Project coverage is 68.61%. Comparing base (fbbd036) to head (45e581a).
Report is 4 commits behind head on main.

Files Patch % Lines
go/vt/sqlparser/ast_format.go 15.21% 39 Missing ⚠️
...vtgate/planbuilder/plancontext/planning_context.go 0.00% 5 Missing ⚠️
.../vtgate/planbuilder/operators/subquery_planning.go 91.66% 3 Missing ⚠️
go/vt/vtgate/semantics/table_collector.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16232      +/-   ##
==========================================
+ Coverage   68.60%   68.61%   +0.01%     
==========================================
  Files        1544     1544              
  Lines      198016   198065      +49     
==========================================
+ Hits       135849   135903      +54     
+ Misses      62167    62162       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@systay systay removed the NeedsIssue A linked issue is missing for this Pull Request label Jun 26, 2024
Signed-off-by: Dirkjan Bussink <[email protected]>
@systay
Copy link
Collaborator Author

systay commented Jun 27, 2024

@dbussink would you mind reviewing this PR?

Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
----------------------------------------------------------------------
----------------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearly some diff I cannot see.

Comment on lines -535 to -554
case *SubQuery:
return pushOrderingToOuterOfSubquery(ctx, in, src)
}
return in, NoRewrite
}

func pushOrderingToOuterOfSubquery(ctx *plancontext.PlanningContext, in *Ordering, sq *SubQuery) (Operator, *ApplyResult) {
outerTableID := TableID(sq.Outer)
for idx, order := range in.Order {
deps := ctx.SemTable.RecursiveDeps(order.Inner.Expr)
if !deps.IsSolvedBy(outerTableID) {
return in, NoRewrite
}
in.Order[idx].SimplifiedExpr = sq.rewriteColNameToArgument(order.SimplifiedExpr)
in.Order[idx].Inner.Expr = sq.rewriteColNameToArgument(order.Inner.Expr)
}
sq.Outer, in.Source = in, sq.Outer
return sq, Rewrote("push ordering into outer side of subquery")
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an unreachable code?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was not used in any of the queries we tested. this is handled pretty early in the planning process, when the subqueries are still inside a SubqueryContainer, so removing this code made no difference

@systay systay merged commit 4922a3a into vitessio:main Jun 27, 2024
94 checks passed
@systay systay deleted the argument-types branch June 27, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DECIMAL Values returned as BIGINT
6 participants