-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rows affected count for multi table update for non-literal column value #16181
fix: rows affected count for multi table update for non-literal column value #16181
Conversation
…n value Signed-off-by: Harshit Gangal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16181 +/- ##
==========================================
+ Coverage 68.54% 68.56% +0.02%
==========================================
Files 1544 1544
Lines 197737 197737
==========================================
+ Hits 135532 135583 +51
+ Misses 62205 62154 -51 ☔ View full report in Codecov by Sentry. |
@@ -146,7 +146,7 @@ func executeNonLiteralUpdate(ctx context.Context, vcursor VCursor, bindVars map[ | |||
if res == nil { | |||
res = qr | |||
} else { | |||
res.RowsAffected += res.RowsAffected | |||
res.RowsAffected += qr.RowsAffected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆
…n value (#16181) Signed-off-by: Harshit Gangal <[email protected]>
…n value (#16181) Signed-off-by: Harshit Gangal <[email protected]>
… non-literal column value (#16181) (#16182) Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
…n-literal column value (#16181) (#16183) Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Description
This PR fixes the calculation for rows affected for a update query with multi table when a column is updated with non-literal value.
Related Issue(s)
Checklist
Deployment Notes