Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtctldclient: Fix Apply (Shard | Keyspace| Table) Routing Rules commands #16096

Merged
merged 11 commits into from
Jun 12, 2024
Merged

vtctldclient: Fix Apply (Shard | Keyspace| Table) Routing Rules commands #16096

merged 11 commits into from
Jun 12, 2024

Commits on Jun 10, 2024

  1. Add e2e test to recreate failure. Fix code bug 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a646f92 View commit details
    Browse the repository at this point in the history

  2. Add tests and fixes for Shard and Keyspace Routing Rules 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    703efa5 View commit details
    Browse the repository at this point in the history

  3. Test both camel case and snake case inputs 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    9b8a530 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Add UnmarshalPB helper 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    e88eda5 View commit details
    Browse the repository at this point in the history

  2. Refactor e2e test 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    103930f View commit details
    Browse the repository at this point in the history

  3. Revert unnecessary change to marshal_test.go 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    b75de50 View commit details
    Browse the repository at this point in the history

  4. Minor refactor unit test 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    1d9de8d View commit details
    Browse the repository at this point in the history

  5. Refactor e2e test 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    a195191 View commit details
    Browse the repository at this point in the history

  6. Reuse UnmarshalPB in Unmarshal 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    62f9a6b View commit details
    Browse the repository at this point in the history

  7. Address review comments 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    ee32b2a View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Address review comments 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    dd0236b View commit details
    Browse the repository at this point in the history