Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in replicationLagModule of go/vt/throttle #16078

Merged

PR suggestions

1da308b
Select commit
Loading
Failed to load commit list.
Merged

Fix race in replicationLagModule of go/vt/throttle #16078

PR suggestions
1da308b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 4, 2024 in 0s

69.42% (-0.01%) compared to 978c59d

View this Pull Request on Codecov

69.42% (-0.01%) compared to 978c59d

Details

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.42%. Comparing base (978c59d) to head (1da308b).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/throttler/replication_lag_cache.go 91.30% 2 Missing ⚠️
go/vt/throttler/throttler.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16078      +/-   ##
==========================================
- Coverage   69.43%   69.42%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      203195   203321     +126     
==========================================
+ Hits       141079   141157      +78     
- Misses      62116    62164      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.