Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] connpool: Allow time out during shutdown (#15979) #16003

Merged
merged 1 commit into from
May 23, 2024

connpool: Allow time out during shutdown (#15979)

c68a316
Select commit
Loading
Failed to load commit list.
Merged

[release-19.0] connpool: Allow time out during shutdown (#15979) #16003

connpool: Allow time out during shutdown (#15979)
c68a316
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 23, 2024 in 0s

67.48% (+0.02%) compared to e49855a

View this Pull Request on Codecov

67.48% (+0.02%) compared to e49855a

Details

Codecov Report

Attention: Patch coverage is 72.72727% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 67.48%. Comparing base (e49855a) to head (c68a316).

Files Patch % Lines
go/vt/vttablet/tabletserver/debugenv.go 0.00% 11 Missing ⚠️
go/pools/smartconnpool/pool.go 91.42% 3 Missing ⚠️
go/vt/vttablet/tabletserver/tabletserver.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #16003      +/-   ##
================================================
+ Coverage         67.46%   67.48%   +0.02%     
================================================
  Files              1560     1560              
  Lines            192839   192856      +17     
================================================
+ Hits             130098   130155      +57     
+ Misses            62741    62701      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.