-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Throwaway PR] For debugging races in multi-tenant locking PR #15936
Closed
rohit-nayak-ps
wants to merge
36
commits into
vitessio:main
from
planetscale:rohit/multi-tenant-routing-rules-locking-rohit-debug
Closed
[Throwaway PR] For debugging races in multi-tenant locking PR #15936
rohit-nayak-ps
wants to merge
36
commits into
vitessio:main
from
planetscale:rohit/multi-tenant-routing-rules-locking-rohit-debug
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
…ace routing rules Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
…r a 'real' topo implementation in addition to memtopo Signed-off-by: Rohit Nayak <[email protected]>
…re created Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
This reverts commit 23dc487. This reverts commit 6119992. This reverts commit f639c60. Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
…on logic to topo server Signed-off-by: Rohit Nayak <[email protected]>
…spaceRoutingRules Signed-off-by: Rohit Nayak <[email protected]>
…k for MoveTables actions. ApplyKeyspaceRoutingRules has been commented out temporarily Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
… e2e test for it Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
…d test. Some additional comments Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
…he client side Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
…rules-locking' into rohit/multi-tenant-routing-rules-locking Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
May 14, 2024
rohit-nayak-ps
changed the title
[Throwaway PR] For debugging races in
[Throwaway PR] For debugging races in multi-tenant locking PR
May 14, 2024
rohit-nayak-ps
force-pushed
the
rohit/multi-tenant-routing-rules-locking-rohit-debug
branch
2 times, most recently
from
May 14, 2024 10:05
1c7a9f1
to
2c82f90
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15936 +/- ##
===========================================
- Coverage 68.40% 8.10% -60.30%
===========================================
Files 1556 783 -773
Lines 195121 106255 -88866
===========================================
- Hits 133479 8617 -124862
- Misses 61642 97638 +35996 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
force-pushed
the
rohit/multi-tenant-routing-rules-locking-rohit-debug
branch
from
May 14, 2024 12:24
f7b3232
to
93592b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Do Not Merge
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds log lines workflow to try to track down races in the codecov workflow.
Tried deleting other workflows but PR shows up as conflicted because of the deleted workflows and refuses to run the codecov workflow :(
#15807
Related Issue(s)
Checklist
Deployment Notes