evalengine: Fix temporal cases in MAKETIME

[beingnoble03]

Description

Precision for time, datetime and timestamp, is the number of decimals in fractional second.
We missed this in MAKETIME

Previously, the tests failed for MAKETIME(1, 2, time'00:00:01.0000') as the function returned TIME("01:02:01.000000") instead of TIME("01:02:01.0000") which wasn't correct as there are 4 decimals in the fractional second on time'00:00:01.0000'.

Related Issue(s)

• evalengine: Support all built-in MySQL functions #9647

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[dbussink]

We're using a lowercase d as the suffix for other decimal related functions, so let's also keep using that here.

[beingnoble03]

we already have Fn_MAKETIME_d for decimal cases, Fn_MAKETIME_D is for the temporal cases, like the one in DATEADD Fn_DATEADD_D

[dbussink]

@beingnoble03 ah, sorry, you're right!

[codecov]

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 68.41%. Comparing base (f118ba2) to head (31bc71b).
Report is 1 commits behind head on main.

Files	Patch %	Lines
go/vt/vtgate/evalengine/compiler_asm.go	85.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15709   +/-   ##
=======================================
  Coverage   68.40%   68.41%           
=======================================
  Files        1556     1556           
  Lines      195121   195168   +47     
=======================================
+ Hits       133479   133518   +39     
- Misses      61642    61650    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.