-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evalengine: Implement REPLACE #15274
Conversation
This implements the REPLACE function. This function is documented as case sensitive, but in practice is also byte sensitive. This means that equal characters under collation rules are not replaced. Signed-off-by: Dirkjan Bussink <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #15274 +/- ##
==========================================
+ Coverage 67.44% 67.49% +0.04%
==========================================
Files 1561 1561
Lines 193193 193297 +104
==========================================
+ Hits 130304 130458 +154
+ Misses 62889 62839 -50 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This implements the REPLACE function. This function is documented as case sensitive, but in practice is also byte sensitive. This means that equal characters under collation rules are not replaced.
Related Issue(s)
Part of #9647
Checklist