Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaxReplicationLagModule.recalculateRate no longer fills the log #14875

Merged
merged 1 commit into from
Jan 16, 2024
Merged

MaxReplicationLagModule.recalculateRate no longer fills the log #14875

merged 1 commit into from
Jan 16, 2024

Conversation

ejortegau
Copy link
Contributor

@ejortegau ejortegau commented Jan 2, 2024 •
edited by mattlord
Loading

Description

This PR removes logging from MaxReplicationLagModule to reduce the noise.
Ideally, this would still be logged in debug mode, but as it turns out, the vitess log does not have a debug mode ¯\_(ツ)_/¯

No need to backport this, though it's so easy that might as well.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

N/A.

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 2, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 2, 2024
@ejortegau ejortegau marked this pull request as ready for review January 2, 2024 16:47
@github-actions github-actions bot added this to the v19.0.0 milestone Jan 2, 2024
@mattlord mattlord removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 3, 2024
@mattlord
Copy link
Contributor

mattlord commented Jan 3, 2024 •
edited
Loading

Thanks, @ejortegau ! I think that it's fine to remove this, but let's also ask @shlomi-noach. If we do want to keep the optional logging for debugging, we could use the verbose glog API: https://github.com/search?q=repo%3Avitessio%2Fvitess+log.v(&type=code

shlomi-noach
shlomi-noach approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove it.

@shlomi-noach
Copy link
Contributor

Re: backporting, I don't think this kind of change falls into the backport guidelines. We can always backport later if needed.

@shlomi-noach shlomi-noach merged commit c1f9c80 into vitessio:main Jan 16, 2024
101 of 104 checks passed
@ejortegau
Copy link
Contributor Author

Thank you!

ejortegau added a commit to slackhq/vitess that referenced this pull request Jan 18, 2024
@ejortegau
MaxReplicationLagModule.recalculateRate no longer fills the log (vite…
6be0320 
…ssio#14875)

Signed-off-by: Eduardo J. Ortega U <[email protected]>
timvaillancourt pushed a commit to slackhq/vitess that referenced this pull request May 27, 2024
@ejortegau @timvaillancourt
MaxReplicationLagModule.recalculateRate no longer fills the log (vite…
9a3aa37 
…ssio#14875)

Signed-off-by: Eduardo J. Ortega U <[email protected]>
@timvaillancourt timvaillancourt mentioned this pull request May 27, 2024
Merged
4 tasks
timvaillancourt added a commit to slackhq/vitess that referenced this pull request May 28, 2024
@timvaillancourt @ejortegau
slack-15.0: backport required Transaction Throttler PRs, pt. 4 (#371)
a3c6f97 
* Skip recalculating the rate in MaxReplicationLagModule when it can't be done (vitessio#12620)

* Skip recalculating the rate in MaxReplicationLagModule when it can't be done

This defends against lag records with nil stats which can lead to segfaults.
See vitessio#12619

Signed-off-by: Eduardo J. Ortega U <[email protected]>

* Address PR comments.

Signed-off-by: Eduardo J. Ortega U <[email protected]>

* Make linter happy

Signed-off-by: Eduardo J. Ortega U <[email protected]>

---------

Signed-off-by: Eduardo J. Ortega U <[email protected]>

* Throttled transactions return MySQL error code 1041 ER_OUT_OF_RESOURCES (vitessio#12949)

This error code seems better suited to represent the fact that transactions are
being throttled by the server due to some form of resource contention than the
current code 1203 ER_TOO_MANY_USER_CONNECTIONS.

Signed-off-by: Eduardo J. Ortega U <[email protected]>

* MaxReplicationLagModule.recalculateRate no longer fills the log (vitessio#14875)

Signed-off-by: Eduardo J. Ortega U <[email protected]>

---------

Signed-off-by: Eduardo J. Ortega U <[email protected]>
Co-authored-by: Eduardo J. Ortega U <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@mattlord mattlord mattlord approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: Throttler Type: Internal Cleanup
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Prevent the MaxReplicationLagModule from flooding the vttablet log
3 participants
@ejortegau @mattlord @shlomi-noach