Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-16.0] Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS with WAIT_FOR_EXECUTED_GTID_SET (#14612) #14620

Merged

Conversation

shlomi-noach
Copy link
Contributor

Description

This is a backport of #14612

Copy link
Contributor

vitess-bot bot commented Nov 27, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@shlomi-noach shlomi-noach merged commit 151b1b0 into vitessio:release-16.0 Nov 28, 2023
115 of 116 checks passed
@shlomi-noach shlomi-noach deleted the backport-14612-to-release-16.0 branch November 28, 2023 05:48
deepthi added a commit to planetscale/vitess that referenced this pull request Dec 9, 2023
…IDS` with `WAIT_FOR_EXECUTED_GTID_SET` (vitessio#14612) (vitessio#14620)"

This reverts commit 151b1b0.

Signed-off-by: deepthi <[email protected]>
GuptaManan100 pushed a commit to planetscale/vitess that referenced this pull request Dec 11, 2023
…IDS` with `WAIT_FOR_EXECUTED_GTID_SET` (vitessio#14612) (vitessio#14620)"

This reverts commit 151b1b0.

Signed-off-by: deepthi <[email protected]>
@deepthi deepthi added Component: TabletManager Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Internal Cleanup and removed Type: Bug Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Dec 13, 2023
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants