-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-17.0] fix: error.as method usage to send pointer to the reference type expected (#13496) #13610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cted. (vitessio#13496) Signed-off-by: Harshit Gangal <[email protected]>
frouioui
added
Type: Bug
Component: Cluster management
Backport
This is a backport
labels
Jul 25, 2023
frouioui
requested review from
harshit-gangal,
systay,
shlomi-noach and
rohit-nayak-ps
as code owners
July 25, 2023 16:50
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jul 25, 2023
frouioui
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Jul 25, 2023
#13590 is superset of this change |
frouioui
added
Backport to: release-15.0
Benchmark me
Add label to PR to run benchmarks
and removed
Backport to: release-15.0
Benchmark me
Add label to PR to run benchmarks
labels
Jul 26, 2023
frouioui
added
Benchmark me
Add label to PR to run benchmarks
and removed
Benchmark me
Add label to PR to run benchmarks
labels
Jul 26, 2023
frouioui
added
Benchmark me
Add label to PR to run benchmarks
and removed
Benchmark me
Add label to PR to run benchmarks
labels
Jul 26, 2023
frouioui
added
Benchmark me
Add label to PR to run benchmarks
and removed
Benchmark me
Add label to PR to run benchmarks
labels
Jul 26, 2023
Hello! 👋 This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked. You can find the performance comparison on the arewefastyet website. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #13496