Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type comparisons for Nullsafe* functions #13605

Merged
merged 8 commits into from
Jul 26, 2023
Merged

Fix type comparisons for Nullsafe* functions #13605

merged 8 commits into from
Jul 26, 2023

Commits on Jul 24, 2023

  1. json: Add better parsing and weights logic 

    Signed-off-by: Dirkjan Bussink <[email protected]>
    @dbussink
    dbussink committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    b0c32a7 View commit details
    Browse the repository at this point in the history

  2. datetime: Fix parsing integers into datetime 

    A 0 time is still valid.

Signed-off-by: Dirkjan Bussink <[email protected]>
    @dbussink
    dbussink committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    a736f83 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Fix parsing datetime 

    A valid month value is at least 1, not at least 0.

Signed-off-by: Dirkjan Bussink <[email protected]>
    @dbussink
    dbussink committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    9f6c613 View commit details
    Browse the repository at this point in the history

  2. sqltypes: Use faster integer parsing logic 

    Signed-off-by: Dirkjan Bussink <[email protected]>
    @dbussink
    dbussink committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    9aab43f View commit details
    Browse the repository at this point in the history

  3. vindexes: Fix collation passing into vindex comparisons 

    Signed-off-by: Dirkjan Bussink <[email protected]>
    @dbussink
    dbussink committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    07a777f View commit details
    Browse the repository at this point in the history

  4. evalengine: Add broader support for type comparisons 

    This implements additional type support for the Nullsafe* family of
functions. It implements a fast path for common types with equal
coercion and then falls back to the generic evalengine logic for all
other cases.

Signed-off-by: Dirkjan Bussink <[email protected]>
    @dbussink
    dbussink committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    7a366ee View commit details
    Browse the repository at this point in the history

  5. evalengine: Use available function for collation 

    Signed-off-by: Dirkjan Bussink <[email protected]>
    @dbussink
    dbussink committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    0e8661b View commit details
    Browse the repository at this point in the history

  6. evalengine: Add back fallback to binary types 

    Signed-off-by: Dirkjan Bussink <[email protected]>
    @dbussink
    dbussink committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    f2b110a View commit details
    Browse the repository at this point in the history