-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-17.0] ignore ongoing backfill vindex from routing selection #13523
Merged
harshit-gangal
merged 1 commit into
vitessio:release-17.0
from
planetscale:r17-cp-13505
Jul 25, 2023
Merged
[release-17.0] ignore ongoing backfill vindex from routing selection #13523
harshit-gangal
merged 1 commit into
vitessio:release-17.0
from
planetscale:r17-cp-13505
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshit-gangal
added
Type: Bug
Component: Query Serving
Backport
This is a backport
labels
Jul 18, 2023
harshit-gangal
requested review from
deepthi,
mattlord,
ajm188,
notfelineit,
frouioui,
rohit-nayak-ps and
GuptaManan100
as code owners
July 18, 2023 07:47
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
harshit-gangal
requested review from
systay,
shlomi-noach,
arthurschreiber,
derekperkins and
dkhenry
as code owners
July 18, 2023 07:47
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jul 18, 2023
harshit-gangal
removed request for
arthurschreiber,
dkhenry,
mattlord,
shlomi-noach,
derekperkins,
ajm188,
notfelineit and
rohit-nayak-ps
July 18, 2023 07:47
harshit-gangal
removed
the
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
label
Jul 18, 2023
harshit-gangal
added
Backport to: release-16.0
and removed
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Jul 18, 2023
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jul 18, 2023
frouioui
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Jul 18, 2023
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
force-pushed
the
r17-cp-13505
branch
from
July 18, 2023 14:49
3a66620
to
b99ceb4
Compare
deepthi
approved these changes
Jul 20, 2023
GuptaManan100
approved these changes
Jul 25, 2023
harshit-gangal
added a commit
that referenced
this pull request
Jul 27, 2023
…13523) Signed-off-by: Harshit Gangal <[email protected]>
frouioui
pushed a commit
that referenced
this pull request
Jul 27, 2023
…13523) (#13607) Co-authored-by: Harshit Gangal <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #13505.