-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new vtctl upgrade downgrade test on release-16.0
#13252
Fix new vtctl upgrade downgrade test on release-16.0
#13252
Conversation
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Florent Poinsard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
One of the tests is still failing: Upgrade Downgrade Testing - Backups - Manual
Do we plan to fix that (either in this PR or separately)?
This is planned in a subsequent PR. |
Description
This PR implements proper filtering of the warning for
vtctlclient
. We will now remove the error produced by a missing or incorrectvtconfig
onrelease-17.0
and above. This is useful to make the upgrade downgrade test pass.