-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable panic in mysqld when socket files are directly used #13198
Merged
rohit-nayak-ps
merged 3 commits into
vitessio:main
from
planetscale:temporarily-disable-panic
Jun 1, 2023
Merged
Temporarily disable panic in mysqld when socket files are directly used #13198
rohit-nayak-ps
merged 3 commits into
vitessio:main
from
planetscale:temporarily-disable-panic
Jun 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erwise some VReplication Workflows are crasing vttablets Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
added
Type: Bug
Component: General
Changes throughout the code base
Backport to: release-16.0
labels
May 30, 2023
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
labels
May 30, 2023
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
deepthi
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
labels
May 30, 2023
Let's create an issue so that we can track both the temporary fix and permanent fix using it. |
deepthi
reviewed
May 30, 2023
Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
removed
the
NeedsIssue
A linked issue is missing for this Pull Request
label
May 31, 2023
mattlord
approved these changes
May 31, 2023
Signed-off-by: Rohit Nayak <[email protected]>
shlomi-noach
approved these changes
Jun 1, 2023
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 26, 2024
…socket files are directly used (vitessio#2310) * cherry pick of 13198 * Fix conflicts Signed-off-by: Rohit Nayak <[email protected]> --------- Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: Rohit Nayak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change in #13123 will cause
MoveTables
workflows to panic in certain cases because they use the mysql CLI directly to create the schema of new tables on the target.The real fix is at #13178. However that has exposed a race where vttablets don't always find the newly created tables. To move forward with the v17 RC1 release we comment out the panic until we find a proper solution for this.
Related Issue(s)
Temporary fix for #13203
Also:
#13123
#13178
Checklist