Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable panic in mysqld when socket files are directly used #13198

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented May 30, 2023

Description

The change in #13123 will cause MoveTables workflows to panic in certain cases because they use the mysql CLI directly to create the schema of new tables on the target.

The real fix is at #13178. However that has exposed a race where vttablets don't always find the newly created tables. To move forward with the v17 RC1 release we comment out the panic until we find a proper solution for this.

Related Issue(s)

Temporary fix for #13203

Also:
#13123
#13178

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

…erwise some VReplication Workflows are crasing vttablets

Signed-off-by: Rohit Nayak <[email protected]>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request labels May 30, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented May 30, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot bot added the NeedsWebsiteDocsUpdate What it says label May 30, 2023
@rohit-nayak-ps rohit-nayak-ps requested a review from a team May 30, 2023 17:10
@github-actions github-actions bot added this to the v17.0.0 milestone May 30, 2023
@deepthi deepthi removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels May 30, 2023
@deepthi
Copy link
Member

deepthi commented May 30, 2023

Let's create an issue so that we can track both the temporary fix and permanent fix using it.

go/vt/mysqlctl/mysqld.go Outdated Show resolved Hide resolved
Signed-off-by: Rohit Nayak <[email protected]>
@rohit-nayak-ps rohit-nayak-ps removed the NeedsIssue A linked issue is missing for this Pull Request label May 31, 2023
@rohit-nayak-ps rohit-nayak-ps requested a review from a team May 31, 2023 11:11
go/vt/mysqlctl/mysqld.go Outdated Show resolved Hide resolved
Signed-off-by: Rohit Nayak <[email protected]>
@rohit-nayak-ps rohit-nayak-ps requested a review from a team June 1, 2023 08:22
@rohit-nayak-ps rohit-nayak-ps merged commit 4fb0b48 into vitessio:main Jun 1, 2023
@rohit-nayak-ps rohit-nayak-ps deleted the temporarily-disable-panic branch June 1, 2023 10:48
frouioui pushed a commit to planetscale/vitess that referenced this pull request Mar 26, 2024
…socket files are directly used (vitessio#2310)

* cherry pick of 13198

* Fix conflicts

Signed-off-by: Rohit Nayak <[email protected]>

---------

Signed-off-by: Rohit Nayak <[email protected]>
Co-authored-by: Rohit Nayak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants