Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in SwitchTraffic that wasn't respecting --dry_run for readonly and replica tablets during a resharding event #12992

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Fix bug in SwitchTraffic that wasn't respecting --dry_run for readonly and replica tablets during a resharding event #12992

merged 2 commits into from
Apr 28, 2023

Commits on Apr 28, 2023

  1. use switcher struct when switching shard reads during a reshard event 

    Signed-off-by: austenLacy <[email protected]>
    @austenLacy
    austenLacy committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    a5ab3c6 View commit details
    Browse the repository at this point in the history

  2. Create failing test for bug reported in vitessio#12992, where a Traff… 

    …icSwitch dry run for reads during resharding tries to actually switch reads and fails

Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps @austenLacy
    rohit-nayak-ps authored and austenLacy committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    99540f4 View commit details
    Browse the repository at this point in the history