Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update v16 release notes about VTGate Advertised MySQL Version #12957

Merged
merged 3 commits into from
Apr 25, 2023
Merged

update v16 release notes about VTGate Advertised MySQL Version #12957

merged 3 commits into from
Apr 25, 2023

Conversation

yoheimuta
Copy link
Contributor

Description

This PR provides a better warning regarding the v16 upgrade: VTGate Advertised MySQL Version is a breaking change for MySQL 5.7 users.

Discussion on Slack: https://vitess.slack.com/archives/C0PQY0PTK/p1682067776047289

Related Issue(s)

Follow up to #11989

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@yoheimuta yoheimuta requested a review from deepthi as a code owner April 24, 2023 06:11
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 24, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 24, 2023 •
edited by frouioui
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v17.0.0 milestone Apr 24, 2023
@frouioui frouioui added Type: Documentation Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 24, 2023
frouioui
frouioui approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@harshit-gangal harshit-gangal merged commit d469008 into vitessio:main Apr 25, 2023
@vitess-bot vitess-bot bot mentioned this pull request Apr 25, 2023
Merged
GuptaManan100 pushed a commit that referenced this pull request May 2, 2023
@vitess-bot @yoheimuta @frouioui
[release-16.0] update v16 release notes about VTGate Advertised MySQL…
199e53c 
… Version (#12957) (#12962)

* update v16 release notes about VTGate Advertised MySQL Version

Signed-off-by: yoheimuta <[email protected]>

* Update changelog/16.0/16.0.0/release_notes.md

Signed-off-by: Florent Poinsard <[email protected]>

* Update changelog/16.0/16.0.0/summary.md

Signed-off-by: Florent Poinsard <[email protected]>

---------

Signed-off-by: yoheimuta <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: yoheimuta <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Documentation
Projects
None yet
Milestone
v17.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yoheimuta @harshit-gangal @frouioui