Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous code modifications based on observations made while doing a code walkthrough #12873

Merged
merged 6 commits into from
Jun 9, 2023
Merged

Miscellaneous code modifications based on observations made while doing a code walkthrough #12873

merged 6 commits into from
Jun 9, 2023

Commits on Jun 9, 2023

  1. Move to glog v1.1.0 

    Signed-off-by: Rohit Nayak <[email protected]>

Miscellaneous fixes based on an internal code audit

Signed-off-by: Rohit Nayak <[email protected]>

More mods

Signed-off-by: Rohit Nayak <[email protected]>

Add modified zkctl.txt

Signed-off-by: Rohit Nayak <[email protected]>

fix imports

Signed-off-by: Manan Gupta <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    9031028 View commit details
    Browse the repository at this point in the history

  2. Address review comments 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    2502acc View commit details
    Browse the repository at this point in the history

  3. Remove statsd.go which came due to an incorrect merge 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    dc77283 View commit details
    Browse the repository at this point in the history

  4. Address review comment 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    0201760 View commit details
    Browse the repository at this point in the history

  5. Update flags help output 

    Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    b8a4154 View commit details
    Browse the repository at this point in the history

  6. Switch back to glog v1.0.0 since moving to glog v1.1.0 trips up zooke… 

    …eper docker tests in Shard 25

Signed-off-by: Rohit Nayak <[email protected]>
    @rohit-nayak-ps
    rohit-nayak-ps committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    99139ce View commit details
    Browse the repository at this point in the history