Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-16.0] Do not fail build on incorrect Go version (#12809) #12812

Merged
merged 3 commits into from
Apr 12, 2023
Merged

[release-16.0] Do not fail build on incorrect Go version (#12809) #12812

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7adf03
Do not fail build on incorrect Go version
frouioui Apr 3, 2023
7b9244e
Remove misleading message in build.env
frouioui Apr 5, 2023
a094756
Merge remote-tracking branch 'origin/release-16.0' into backport-1280…
frouioui Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
source ./tools/shell_functions.inc

go version >/dev/null 2>&1 || fail "Go is not installed or is not in \$PATH. See https://vitess.io/contributing/build-from-source for install instructions."
goversion_min 1.20.3 || fail "Go version reported: `go version`. Version 1.20.3+ required. See https://vitess.io/contributing/build-from-source for install instructions."
goversion_min 1.20.3 || echo "Go version reported: `go version`. Version 1.20.3+ recommended. See https://vitess.io/contributing/build-from-source for install instructions."

mkdir -p dist
mkdir -p bin
Expand Down