Commits on Mar 28, 2023

1. Flakes: Use new healthy shard check in vreplication e2e tests (vitess… …

   …io#12502)
   
   * Use new healthy shard check in vreplication e2e tests
   
   This is needed because checking that there's a primary tablet for
   the shard in vtgate's healtcheck is no longer a reliable indicator
   that the shard has a healthy serving primary, because now a
   primary needs to initialize its sidecar database and wait for
   that to replicate via semi-sync before it becomes serving and can
   proceed to perform normal functions. So this delay could cause
   test flakiness if you required a healthy shard before continuing
   with the test.
   
   Signed-off-by: Matt Lord <[email protected]>
   
   * Try to address unit test race flakes around log size
   
   They looked like this:
   WARNING: DATA RACE
   Write at 0x000005bf9b60 by goroutine 27141:
     github.com/spf13/pflag.newUint64Value()
         /home/runner/go/pkg/mod/github.com/spf13/[email protected]/uint64.go:9 +0x5a
     github.com/spf13/pflag.(*FlagSet).Uint64Var()
         /home/runner/go/pkg/mod/github.com/spf13/[email protected]/uint64.go:45 +0x55
     vitess.io/vitess/go/vt/log.RegisterFlags()
         /home/runner/work/vitess/vitess/go/vt/log/log.go:81 +0x64
     vitess.io/vitess/go/vt/servenv.GetFlagSetFor()
         /home/runner/work/vitess/vitess/go/vt/servenv/servenv.go:347 +0x183
     vitess.io/vitess/go/vt/servenv.ParseFlags()
         /home/runner/work/vitess/vitess/go/vt/servenv/servenv.go:326 +0x49
   ...
   Previous read at 0x000005bf9b60 by goroutine 27136:
   1744
     github.com/golang/glog.(*syncBuffer).Write()
   ...
   
   And they most often occurred in the wrangler unit tests, which makes sense
   because it creates a log of loggers.
   
   Signed-off-by: Matt Lord <[email protected]>
   
   * Revert "Try to address unit test race flakes around log size"
   
   This reverts commit 51992b8.
   
   Signed-off-by: Matt Lord <[email protected]>
   
   * Use external cluster vtctld in TestMigrate
   
   Signed-off-by: Matt Lord <[email protected]>
   
   * Use subshell vs command output interpolation
   
   Signed-off-by: Matt Lord <[email protected]>
   
   * Ingnore any config files in mysql alias
   
   Signed-off-by: Matt Lord <[email protected]>
   
   ---------
   
   Signed-off-by: Matt Lord <[email protected]>

   

   mattlord authored and GuptaManan100 committed Mar 28, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 3ff6d38
   • Browse repository at this point

   Copy the full SHA

   3ff6d38 View commit details

   Browse the repository at this point in the history