Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-16.0] Upgrade the Golang version to go1.20.2 #12723

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 24, 2023

This Pull Request bumps the Golang version to go1.20.2 and the bootstrap version to 14.2.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are a few manual steps remaining:

  • Make sure you update the Golang version used in the previous and next release branches for the Upgrade/Downgrade tests.
  • Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.
  • Update the ./.github/workflows/*.yml files with the newer Golang version, the bot cannot handle that due to permissions.
    • To accomplish this, run the following: go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.20.2

@github-actions github-actions bot added Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go labels Mar 24, 2023
@github-actions github-actions bot requested a review from deepthi as a code owner March 24, 2023 10:03
@github-actions github-actions bot added Skip CI Skip CI actions from running Type: CI/Build labels Mar 24, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 24, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 24, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui removed Skip CI Skip CI actions from running NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 24, 2023
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting for the benchmarks to show up, the rest looks good to me.

@frouioui frouioui mentioned this pull request Mar 24, 2023
34 tasks
@github-actions github-actions bot added the Skip CI Skip CI actions from running label Mar 25, 2023
@github-actions github-actions bot force-pushed the upgrade-go-to-1.20.2-on-release-16.0 branch 2 times, most recently from 6626e24 to 8e2d49a Compare March 26, 2023 00:25
@github-actions github-actions bot force-pushed the upgrade-go-to-1.20.2-on-release-16.0 branch from 8e2d49a to 3dcfd22 Compare March 27, 2023 00:23
@frouioui frouioui closed this Mar 27, 2023
@frouioui frouioui reopened this Mar 27, 2023
@frouioui frouioui removed the Skip CI Skip CI actions from running label Mar 27, 2023
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui force-pushed the upgrade-go-to-1.20.2-on-release-16.0 branch from a006da8 to 8b9bd8f Compare March 27, 2023 09:15
@frouioui frouioui merged commit a1bb778 into release-16.0 Mar 27, 2023
@frouioui frouioui deleted the upgrade-go-to-1.20.2-on-release-16.0 branch March 27, 2023 11:48
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go Type: CI/Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants