-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-16.0] Upgrade the Golang version to go1.20.2
#12723
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
GuptaManan100,
frouioui and
rohit-nayak-ps
as code owners
March 24, 2023 10:03
github-actions
bot
added
Benchmark me
Add label to PR to run benchmarks
Component: General
Changes throughout the code base
go
labels
Mar 24, 2023
github-actions
bot
requested review from
mattlord,
harshit-gangal,
derekperkins and
dkhenry
as code owners
March 24, 2023 10:03
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
labels
Mar 24, 2023
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
frouioui
removed
Skip CI
Skip CI actions from running
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
labels
Mar 24, 2023
frouioui
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still waiting for the benchmarks to show up, the rest looks good to me.
github-actions
bot
force-pushed
the
upgrade-go-to-1.20.2-on-release-16.0
branch
2 times, most recently
from
March 26, 2023 00:25
6626e24
to
8e2d49a
Compare
Signed-off-by: GitHub <[email protected]>
github-actions
bot
force-pushed
the
upgrade-go-to-1.20.2-on-release-16.0
branch
from
March 27, 2023 00:23
8e2d49a
to
3dcfd22
Compare
shlomi-noach
approved these changes
Mar 27, 2023
dbussink
approved these changes
Mar 27, 2023
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
force-pushed
the
upgrade-go-to-1.20.2-on-release-16.0
branch
from
March 27, 2023 09:15
a006da8
to
8b9bd8f
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Benchmark me
Add label to PR to run benchmarks
Component: General
Changes throughout the code base
go
Type: CI/Build
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request bumps the Golang version to
go1.20.2
and the bootstrap version to14.2
.There are a few manual steps remaining:
./.github/workflows/*.yml
files with the newer Golang version, the bot cannot handle that due to permissions.go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.20.2