-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run launchable only on PRs against main
#12694
Merged
GuptaManan100
merged 3 commits into
vitessio:main
from
planetscale:launchable-integration
Mar 24, 2023
Merged
Run launchable only on PRs against main
#12694
GuptaManan100
merged 3 commits into
vitessio:main
from
planetscale:launchable-integration
Mar 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuptaManan100
requested review from
frouioui,
rohit-nayak-ps,
deepthi,
mattlord and
harshit-gangal
as code owners
March 22, 2023 11:31
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
force-pushed
the
launchable-integration
branch
from
March 22, 2023 11:32
498feed
to
78bebb2
Compare
Signed-off-by: Manan Gupta <[email protected]>
frouioui
reviewed
Mar 22, 2023
frouioui
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have one question, otherwise LGTM
deepthi
approved these changes
Mar 22, 2023
mattlord
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
GuptaManan100
added a commit
to planetscale/vitess
that referenced
this pull request
Mar 24, 2023
* feat: reenable launchable for unit_tests Signed-off-by: Manan Gupta <[email protected]> * feat: only run CI on PRs against main Signed-off-by: Manan Gupta <[email protected]> * feat: use base_ref instead of ref Signed-off-by: Manan Gupta <[email protected]> --------- Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
added a commit
that referenced
this pull request
Mar 27, 2023
* feat: reenable launchable for unit_tests * feat: only run CI on PRs against main * feat: use base_ref instead of ref --------- Signed-off-by: Manan Gupta <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check to setup of
launchable
step of the workflows to only run when the PR is made againstmain
Related Issue(s)
Checklist
Deployment Notes