Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run launchable only on PRs against main #12694

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

GuptaManan100
Copy link
Member

Description

This PR adds a check to setup of launchable step of the workflows to only run when the PR is made against main

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have one question, otherwise LGTM

Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@GuptaManan100 GuptaManan100 merged commit efaf882 into vitessio:main Mar 24, 2023
@GuptaManan100 GuptaManan100 deleted the launchable-integration branch March 24, 2023 07:33
GuptaManan100 added a commit to planetscale/vitess that referenced this pull request Mar 24, 2023
* feat: reenable launchable for unit_tests

Signed-off-by: Manan Gupta <[email protected]>

* feat: only run CI on PRs against main

Signed-off-by: Manan Gupta <[email protected]>

* feat: use base_ref instead of ref

Signed-off-by: Manan Gupta <[email protected]>

---------

Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100 added a commit that referenced this pull request Mar 27, 2023
* feat: reenable launchable for unit_tests



* feat: only run CI on PRs against main



* feat: use base_ref instead of ref



---------

Signed-off-by: Manan Gupta <[email protected]>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants