[release-16.0] Make sure to not push down expressions when not possible (#12607) #12648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le (vitessio#12607) * Fix random aggregation to not select Null column Signed-off-by: Florent Poinsard <[email protected]> * stop pushing down projections that should be evaluated at the vtgate level Signed-off-by: Andres Taylor <[email protected]> * undo changes to AggregateRandom Signed-off-by: Andres Taylor <[email protected]> * clean up code Signed-off-by: Andres Taylor <[email protected]> * fix executor test mock Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Andres Taylor <[email protected]> Co-authored-by: Andres Taylor <[email protected]>
frouioui
requested review from
harshit-gangal,
systay,
GuptaManan100 and
arthurschreiber
as code owners
GuptaManan100
approved these changes
Mar 17, 2023
systay
approved these changes
Mar 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #12607