Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-16.0] Tooling improvements backports #12528

Merged
merged 2 commits into from
Mar 2, 2023
Merged

[release-16.0] Tooling improvements backports #12528

merged 2 commits into from
Mar 2, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Mar 1, 2023

Description

This is a backport of #12489 and #12487

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@frouioui
Improve release process post v16.0.0 GA code freeze (vitessio#12487)
db10c63 
* Update the release instructions document with pre-requisites for release team

Signed-off-by: Florent Poinsard <[email protected]>

* Add Do Not Merge to release Pull Request upon creation

Signed-off-by: Florent Poinsard <[email protected]>

---------

Signed-off-by: Florent Poinsard <[email protected]>
@frouioui
Block merge if the Do Not Merge label is set (vitessio#12489)
e3ec503 
* Block Merge if the  label is set

Signed-off-by: Florent Poinsard <[email protected]>

* fix echo syntax

Signed-off-by: Florent Poinsard <[email protected]>

---------

Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Build/CI Backport This is a backport Type: Release labels Mar 1, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 1, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 1, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 1, 2023
@frouioui frouioui requested a review from dbussink March 1, 2023 08:54
rohit-nayak-ps
rohit-nayak-ps approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@frouioui frouioui merged commit fbfc366 into vitessio:release-16.0 Mar 2, 2023
@frouioui frouioui deleted the bp-tooling-improvements-on-16 branch March 2, 2023 09:46
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@rsajwani rsajwani Awaiting requested review from rsajwani rsajwani is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@dbussink dbussink Awaiting requested review from dbussink

Assignees
No one assigned
Labels
Backport This is a backport Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frouioui @GuptaManan100 @rohit-nayak-ps