Support BETWEEN in the evalengine #12150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
dbussink
reviewed
Jan 25, 2023
Signed-off-by: Andres Taylor <[email protected]>
systay
added
Type: Enhancement
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
frouioui
approved these changes
Jan 25, 2023
arthurschreiber
approved these changes
Jan 25, 2023
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
dbussink
pushed a commit
that referenced
this pull request
Jan 30, 2023
* add translation for between comparisons in the evalengine Signed-off-by: Andres Taylor <[email protected]> * add end to end test Signed-off-by: Andres Taylor <[email protected]> * add support for NOT BETWEEN Signed-off-by: Andres Taylor <[email protected]> * fix translation of NOT BETWEEN Signed-off-by: Andres Taylor <[email protected]> * assert no matter the order of the results Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Andres Taylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
BETWEENin the eval engine, by translating them to=>and=<comparisons, or the equivalent for `NOT BETWEEN.Related Issue(s)
Solves part of #9647
Checklist