Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDL: do not Reload() for 'CREATE TEMPORARY' and 'DROP TEMPORARY' statements #12144

Merged
merged 5 commits into from
Jan 25, 2023
Merged

DDL: do not Reload() for 'CREATE TEMPORARY' and 'DROP TEMPORARY' statements #12144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84dfc5b
DDL: do not Reload() for 'CREATE TEMPORARY' and 'DROP TEMPORARY' stat…
shlomi-noach Jan 25, 2023
db12da4
simplified check for temporary table
shlomi-noach Jan 25, 2023
718156f
simplified check again for temporary table
shlomi-noach Jan 25, 2023
08acc00
added plan test to see NeedsReservedConn is true for temporary table …
harshit-gangal Jan 25, 2023
24e7c22
added schema reload timing metric and add test to verify if reload ex…
harshit-gangal Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion go/vt/vttablet/tabletserver/planbuilder/plan_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,17 @@ func (p *Plan) MarshalJSON() ([]byte, error) {
}

func TestPlan(t *testing.T) {
testPlan(t, "exec_cases.txt")
}

func TestDDLPlan(t *testing.T) {
testPlan(t, "ddl_cases.txt")
}

func testPlan(t *testing.T, fileName string) {
t.Helper()
testSchema := loadSchema("schema_test.json")
for tcase := range iterateExecFile("exec_cases.txt") {
for tcase := range iterateExecFile(fileName) {
t.Run(tcase.input, func(t *testing.T) {
if strings.Contains(tcase.options, "PassthroughDMLs") {
PassthroughDMLs = true
Expand Down
270 changes: 234 additions & 36 deletions go/vt/vttablet/tabletserver/planbuilder/testdata/ddl_cases.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,118 +1,316 @@
"create table a(abcd)"
"create table a(abcd bigint)"
{
"Action": "create"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "a",
"Role": 2
}
],
"FullQuery": "create table a (\n\tabcd bigint\n)"
}

"drop table b"
{
"Action": "drop"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "b",
"Role": 2
}
],
"FullQuery": "drop table b"
}

"drop table b.c"
{
"Action": "drop"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "c",
"Role": 2
}
],
"FullQuery": "drop table b.c"
}

"alter table c alter foo"
"alter table c add column foo bigint"
{
"Action": "alter"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "c",
"Role": 2
}
],
"FullQuery": "alter table c add column foo bigint"
}

"alter table c comment 'aa'"
{
"Action": "alter"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "c",
"Role": 2
}
],
"FullQuery": "alter table c comment 'aa'"
}

"alter table b.c comment 'aa'"
{
"Action": "alter"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "c",
"Role": 2
}
],
"FullQuery": "alter table b.c comment 'aa'"
}

"drop index a on b"
{
"Action": "alter"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "b",
"Role": 2
}
],
"FullQuery": "alter table b drop key a"
}

"drop index a on b.c"
{
"Action": "alter"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "c",
"Role": 2
}
],
"FullQuery": "alter table b.c drop key a"
}

"drop index a on b lock=none"
{
"Action": "alter"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "b",
"Role": 2
}
],
"FullQuery": "alter table b drop key a, lock none"
}

"rename table a to b"
{
"Action": "rename"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "a",
"Role": 2
},
{
"TableName": "b",
"Role": 2
}
],
"FullQuery": "rename table a to b"
}

"rename table c.a to c.b"
{
"Action": "rename"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "a",
"Role": 2
},
{
"TableName": "b",
"Role": 2
}
],
"FullQuery": "rename table c.a to c.b"
}


"alter table a rename b"
{
"Action": "rename"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "a",
"Role": 2
},
{
"TableName": "b",
"Role": 2
}
],
"FullQuery": "alter table a rename b"
}

"alter table a rename to b"
{
"Action": "rename"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "a",
"Role": 2
},
{
"TableName": "b",
"Role": 2
}
],
"FullQuery": "alter table a rename b"
}


"alter table c.a rename to c.b"
{
"Action": "rename"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "a",
"Role": 2
},
{
"TableName": "b",
"Role": 2
}
],
"FullQuery": "alter table c.a rename c.b"
}

"create view a asdasd"
"create view a as select * from asdasd"
{
"Action": "create"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "a",
"Role": 2
}
],
"FullQuery": "create view a as select * from asdasd"
}

# syntax error
"alter view c as foo"
{
"Action": "alter"
}
"syntax error at position 20 near 'foo'"

"drop view b"
{
"Action": "drop"
}

"select * from a"
{
"Action": ""
}

"syntax error"
{
"Action": ""
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "b",
"Role": 2
}
],
"FullQuery": "drop view b"
}

"alter table a reorganize partition b into (partition c values less than (1000), partition d values less than (maxvalue))"
{
"Action": "alter"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "a",
"Role": 2
}
],
"FullQuery": "alter table a reorganize partition b into (partition c values less than (1000), partition d values less than maxvalue)"
}

"alter table a partition by range (id) (partition p0 values less than (10), partition p1 values less than (maxvalue))"
{
"Action": "alter"
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "a",
"Role": 2
}
],
"FullQuery": "alter table a \npartition by range (id)\n(partition p0 values less than (10),\n partition p1 values less than maxvalue)"
}

# truncate
"truncate a"
{
"PlanID": "DDL",
"TableName": "a"
"TableName": "",
"Permissions": [
{
"TableName": "a",
"Role": 2
}
],
"FullQuery": "truncate table a"
}

# truncate
"truncate table a"
{
"PlanID": "DDL",
"TableName": "a"
"TableName": "",
"Permissions": [
{
"TableName": "a",
"Role": 2
}
],
"FullQuery": "truncate table a"
}

# create a temporary table
"create temporary table a(id bigint primary key)"
{
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "a",
"Role": 2
}
],
"FullQuery": "create temporary table a (\n\tid bigint primary key\n)",
"NeedsReservedConn": true
}

# temporary table with ddl statement only partially parsed
"create temporary table x"
{
"PlanID": "DDL",
"TableName": "",
"Permissions": [
{
"TableName": "x",
"Role": 2
}
],
"NeedsReservedConn": true
}
Loading