Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidating OnlineDDL 'declarative' tests into 'scheduler' tests: part 1 #12061

Merged
merged 3 commits into from
Jan 29, 2023
Merged

consolidating OnlineDDL 'declarative' tests into 'scheduler' tests: part 1 #12061

merged 3 commits into from
Jan 29, 2023

Conversation

shlomi-noach
Copy link
Contributor

Description

Similarly to #12055, the onlineddl_scheduler tests now include testing for declarative, effectively making onlineddl_declarative redundant.

In this PR we do not yet remove onlineddl_declarative, because we can't atomically merge the PR while removing a required test from the very same PR. A followup PR will remove both onlineddl_singleton and onlineddl_declarative tests and workflows.

The objective of this change is to reduce CI workflow files.

Related Issue(s)

#6926

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 10, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@shlomi-noach shlomi-noach mentioned this pull request Jan 10, 2023
Merged
3 tasks
@shlomi-noach
increase test timeout
b3a5e92 
Signed-off-by: Shlomi Noach <[email protected]>
mattlord
mattlord approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some minor questions/comments, but nothing blocking. Thank you again! ❤️

go/test/endtoend/onlineddl/scheduler/onlineddl_scheduler_test.go
t.Run("init: drop table", func(t *testing.T) {
// IF EXISTS is not supported in -declarative
uuid := testOnlineDDL(t, dropIfExistsStatement, "online", "vtgate", "", "")
onlineddl.CheckMigrationStatus(t, &vtParams, shards, uuid, schema.OnlineDDLStatusComplete)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why we have this and the following subtest here since they don't use declarative? IMO we should remove them as we're not testing the feature and we DO have subtests that confirm they fail.

Same holds true for all of the subtests which aren't using declarativeStrategy. Perhaps there's good reason to have them here though, which is fine. I do see that you had a comment about this for some towards the end (they're not declarative but fit best in this test).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular execution ensures the table does not exist before we begin the actual declarative testing. In onlineddl_declarative this was not required, since we started with an empty cluster. But now that we have converged multiple tests into a single workflow, we need to perform pre-test cleanup. Specifically, the particular table actually does exist from a previous test.
I'm not using -declarative in this DROP TABLE because I want a "trusted" method before embarking on -declarative validations.

go/test/endtoend/onlineddl/scheduler/onlineddl_scheduler_test.go Outdated Show resolved Hide resolved
@shlomi-noach
fixed comments
0085cdd 
Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach shlomi-noach requested a review from a team January 23, 2023 05:46
@shlomi-noach
Copy link
Contributor Author

ping for review 🙏

@shlomi-noach
Copy link
Contributor Author

Looking for a 2nd review

rohit-nayak-ps
rohit-nayak-ps approved these changes Jan 29, 2023
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shlomi-noach shlomi-noach merged commit 390ddad into vitessio:main Jan 29, 2023
@shlomi-noach shlomi-noach deleted the onlineddl-consolidate-declarative-tests branch January 29, 2023 12:42
@shlomi-noach shlomi-noach mentioned this pull request Jan 29, 2023
Merged
3 tasks
@shlomi-noach
Copy link
Contributor Author

Followup in #12182

@shlomi-noach shlomi-noach mentioned this pull request Jan 29, 2023
Merged
3 tasks
dbussink pushed a commit that referenced this pull request Jan 30, 2023
@shlomi-noach
consolidating OnlineDDL 'declarative' tests into 'scheduler' tests: p…
215543c 
…art 1 (#12061) (#1536)

* consolidating OnlineDDL 'declarative' tests into 'scheduler' tests: part 1



* increase test timeout



* fixed comments



---------

Signed-off-by: Shlomi Noach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@mattlord mattlord mattlord approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

Assignees
No one assigned
Labels
Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shlomi-noach @mattlord @rohit-nayak-ps