Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Remove Deprecated V1 Client Commands #11705

Merged
merged 10 commits into from
Nov 30, 2022

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Nov 14, 2022

Description

This removes the VReplication v1 client commands that have were deprecated in Vitess 11.0.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were updated
  • Documentation will need to be updated in many places and will be done as part of: [Docs Review] All VReplication Docs website#1212 Which I will work on next.
    • Note: I will also add a warning to the v15- docs v1 pages that they have been removed in v16

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 14, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@mattlord mattlord force-pushed the vrepl_rm_v1 branch 2 times, most recently from d474193 to 38a8190 Compare November 15, 2022 00:04
@mattlord mattlord added the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Nov 15, 2022
@mattlord mattlord force-pushed the vrepl_rm_v1 branch 4 times, most recently from 25c09d8 to 184a515 Compare November 16, 2022 02:26
@mattlord mattlord marked this pull request as ready for review November 16, 2022 22:35
@mattlord mattlord removed the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Nov 16, 2022
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mattlord mattlord merged commit dd49816 into vitessio:main Nov 30, 2022
@mattlord mattlord deleted the vrepl_rm_v1 branch November 30, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: delete VReplication v1 workflow related code
3 participants