-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: Remove Deprecated V1 Client Commands #11705
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
mattlord
force-pushed
the
vrepl_rm_v1
branch
2 times, most recently
from
November 15, 2022 00:04
d474193
to
38a8190
Compare
mattlord
added
the
release notes (needs details)
This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...)
label
Nov 15, 2022
mattlord
force-pushed
the
vrepl_rm_v1
branch
4 times, most recently
from
November 16, 2022 02:26
25c09d8
to
184a515
Compare
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
vrepl_rm_v1
branch
from
November 16, 2022 03:44
184a515
to
548ae9a
Compare
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
vrepl_rm_v1
branch
from
November 16, 2022 05:50
4bee39c
to
358e8b4
Compare
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
mattlord
requested review from
deepthi,
rohit-nayak-ps,
notfelineit,
frouioui,
GuptaManan100 and
rsajwani
as code owners
November 16, 2022 22:35
mattlord
removed
the
release notes (needs details)
This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...)
label
Nov 16, 2022
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
rohit-nayak-ps
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
deepthi
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Signed-off-by: Matt Lord <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the VReplication v1 client commands that have were deprecated in Vitess 11.0.
Related Issue(s)
Checklist